Page MenuHomePhabricator

Add Builder::getI64VectorAttr.
ClosedPublic

Authored by silvas on Mar 9 2020, 4:11 PM.

Details

Summary

This matches Builder::getI32VectorAttr.

Diff Detail

Event Timeline

silvas created this revision.Mar 9 2020, 4:11 PM
Herald added 1 blocking reviewer(s): rriddle. · View Herald TranscriptMar 9 2020, 4:11 PM
Herald added a project: Restricted Project. · View Herald Transcript
silvas added a comment.Mar 9 2020, 4:15 PM

Let me know if you want me to add a unittest. Couldn't find any intree users to update.

bondhugula requested changes to this revision.Mar 9 2020, 9:23 PM
bondhugula added a subscriber: bondhugula.
bondhugula added inline comments.
mlir/lib/IR/Builders.cpp
113

AFAIR, you can just do `DenseIntElementsAttr::get``` - you don't need the trailing cast. The method right above can also be fixed the same way.

This revision now requires changes to proceed.Mar 9 2020, 9:23 PM
rriddle accepted this revision.Mar 11 2020, 10:34 AM

LGTM after resolving Uday's comment.

silvas updated this revision to Diff 249778.Mar 11 2020, 3:15 PM
silvas marked an inline comment as done.

Update for Uday's comment.

mlir/lib/IR/Builders.cpp
113

Done!

bondhugula accepted this revision.Mar 11 2020, 8:44 PM
This revision is now accepted and ready to land.Mar 11 2020, 8:44 PM
This revision was automatically updated to reflect the committed changes.