This is an archive of the discontinued LLVM Phabricator instance.

Fix a copy and paste error that would cause a crash.
ClosedPublic

Authored by clayborg on Mar 6 2020, 3:01 PM.

Details

Summary

The wrong variable was being checked for an error, which mean a llvm::Error went unchecked and crashes dsymutil. Discovered this when trying to feed an ELF file to "dsymutil --update" and running into the crash.

Diff Detail

Event Timeline

clayborg created this revision.Mar 6 2020, 3:01 PM
Herald added a project: Restricted Project. · View Herald Transcript
JDevlieghere accepted this revision.Mar 6 2020, 3:34 PM

Good catch, thanks for fixing that. LGTM.

This revision is now accepted and ready to land.Mar 6 2020, 3:34 PM
This revision was automatically updated to reflect the committed changes.