[libc] [NFC] Use matchers in tests

[abrachet]

Summary

Use EXPECT_THAT where possible in tests NFC intended.

Added a void * template instantiation of StreamWrapper::operator<<

libc/test/src/signal/sigprocmask_test.cpp

 //===--------------------- Unittests for sigprocmask ----------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 #include "include/errno.h"
 #include "include/signal.h"
 #include "src/errno/llvmlibc_errno.h"
 #include "src/signal/raise.h"
 #include "src/signal/sigaddset.h"
 #include "src/signal/sigemptyset.h"
 #include "src/signal/sigprocmask.h"
 
+#include "utils/UnitTest/ErrnoSetterMatcher.h"
 #include "utils/UnitTest/Test.h"
 
 class SignalTest : public __llvm_libc::testing::Test {
   sigset_t oldSet;
 
 public:
   void SetUp() override { __llvm_libc::sigprocmask(0, nullptr, &oldSet); }
 
   void TearDown() override {
     __llvm_libc::sigprocmask(SIG_SETMASK, &oldSet, nullptr);
   }
 };
 
+using __llvm_libc::testing::ErrnoSetterMatcher::Fails;
+using __llvm_libc::testing::ErrnoSetterMatcher::Succeeds;
+
 // This tests for invalid input.
 TEST_F(SignalTest, SigprocmaskInvalid) {
-  sigset_t valid;
-  // 17 and -4 are out of the range for sigprocmask's how paramater.
   llvmlibc_errno = 0;
-  EXPECT_EQ(__llvm_libc::sigprocmask(17, &valid, nullptr), -1);
-  EXPECT_EQ(llvmlibc_errno, EINVAL);
 
-  llvmlibc_errno = 0;
-  EXPECT_EQ(__llvm_libc::sigprocmask(-4, &valid, nullptr), -1);
-  EXPECT_EQ(llvmlibc_errno, EINVAL);
+  sigset_t valid;
+  // 17 and -4 are out of the range for sigprocmask's how paramater.
+  EXPECT_THAT(__llvm_libc::sigprocmask(17, &valid, nullptr), Fails(EINVAL));
+  EXPECT_THAT(__llvm_libc::sigprocmask(-4, &valid, nullptr), Fails(EINVAL));
 
   // This pointer is out of this processes address range.
   sigset_t *invalid = reinterpret_cast<sigset_t *>(-1);
-
-  llvmlibc_errno = 0;
-  EXPECT_EQ(__llvm_libc::sigprocmask(SIG_SETMASK, invalid, nullptr), -1);
-  EXPECT_EQ(llvmlibc_errno, EFAULT);
-
-  llvmlibc_errno = 0;
-  EXPECT_EQ(__llvm_libc::sigprocmask(-4, nullptr, invalid), -1);
-  EXPECT_EQ(llvmlibc_errno, EFAULT);
+  EXPECT_THAT(__llvm_libc::sigprocmask(SIG_SETMASK, invalid, nullptr),
+              Fails(EFAULT));
+  EXPECT_THAT(__llvm_libc::sigprocmask(-4, nullptr, invalid), Fails(EFAULT));
 }
 
 // This tests that when nothing is blocked, a process gets killed and alse tests
 // that when signals are blocked they are not delivered to the process.
 TEST_F(SignalTest, BlockUnblock) {
   sigset_t sigset;
   EXPECT_EQ(__llvm_libc::sigemptyset(&sigset), 0);
   EXPECT_EQ(__llvm_libc::sigprocmask(SIG_SETMASK, &sigset, nullptr), 0);
   EXPECT_DEATH([] { __llvm_libc::raise(SIGUSR1); }, SIGUSR1);
   EXPECT_EQ(__llvm_libc::sigaddset(&sigset, SIGUSR1), 0);
   EXPECT_EQ(__llvm_libc::sigprocmask(SIG_SETMASK, &sigset, nullptr), 0);
   EXPECT_EXITS([] { __llvm_libc::raise(SIGUSR1); }, 0);
 }

libc/test/src/sys/mman/linux/mmap_test.cpp

 //===------------------ Unittests for mmap and munmap ---------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 #include "include/errno.h"
 #include "include/sys/mman.h"
 #include "src/errno/llvmlibc_errno.h"
 #include "src/sys/mman/mmap.h"
 #include "src/sys/mman/munmap.h"
+#include "utils/UnitTest/ErrnoSetterMatcher.h"
 #include "utils/UnitTest/Test.h"
 
+using __llvm_libc::testing::ErrnoSetterMatcher::Fails;
+using __llvm_libc::testing::ErrnoSetterMatcher::Succeeds;
+
 TEST(MMapTest, NoError) {
   size_t alloc_size = 128;
   llvmlibc_errno = 0;
   void *addr = __llvm_libc::mmap(nullptr, alloc_size, PROT_READ,
                                  MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
   EXPECT_EQ(0, llvmlibc_errno);
   EXPECT_NE(addr, MAP_FAILED);
 
   int *array = reinterpret_cast<int *>(addr);
   // Reading from the memory should not crash the test.
   // Since we used the MAP_ANONYMOUS flag, the contents of the newly
   // allocated memory should be initialized to zero.
   EXPECT_EQ(array[0], 0);
-
-  int ret_val = __llvm_libc::munmap(addr, alloc_size);
-  EXPECT_EQ(0, ret_val);
-  EXPECT_EQ(0, llvmlibc_errno);
+  EXPECT_THAT(__llvm_libc::munmap(addr, alloc_size), Succeeds());
 }
 
 TEST(MMapTest, Error_InvalidSize) {
   llvmlibc_errno = 0;
   void *addr = __llvm_libc::mmap(nullptr, 0, PROT_READ,
                                  MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
-  EXPECT_EQ(EINVAL, llvmlibc_errno);
-  EXPECT_EQ(addr, MAP_FAILED);
+  EXPECT_THAT(addr, Fails(EINVAL, MAP_FAILED));
 
-  llvmlibc_errno = 0;
-  int ret_val = __llvm_libc::munmap(0, 0);
-  EXPECT_EQ(-1, ret_val);
-  EXPECT_EQ(EINVAL, llvmlibc_errno);
+  EXPECT_THAT(__llvm_libc::munmap(0, 0), Fails(EINVAL));
 }

libc/utils/testutils/StreamWrapper.cpp

 
 template <typename T> StreamWrapper &StreamWrapper::operator<<(T t) {
   assert(OS);
   llvm::raw_ostream &Stream = *reinterpret_cast<llvm::raw_ostream *>(OS);
   Stream << t;
   return *this;
 }
 
+template StreamWrapper &StreamWrapper::operator<<<void *>(void *t);
 template StreamWrapper &StreamWrapper::operator<<<const char *>(const char *t);
 template StreamWrapper &StreamWrapper::operator<<<char *>(char *t);
 template StreamWrapper &StreamWrapper::operator<<<char>(char t);
 template StreamWrapper &StreamWrapper::operator<<<short>(short t);
 template StreamWrapper &StreamWrapper::operator<<<int>(int t);
 template StreamWrapper &StreamWrapper::operator<<<long>(long t);
 template StreamWrapper &StreamWrapper::operator<<<long long>(long long t);
 template StreamWrapper &