Page MenuHomePhabricator

[lld] Rename -flavor darwin to -flavor old-darwin
Needs ReviewPublic

Authored by MaskRay on Mar 4 2020, 2:48 PM.

Details

Summary

@lhames agreed to remove the existing Mach-O port from lld
(https://reviews.llvm.org/D75382#1906108), but we should probably
continue keeping it until the new Mach-O port gets matured. The existing
Mach-O is also used by some downstream projects like Zig.

This patch is similar to rL253188 "Rename the gnu flavour to gnu old."
When the new Mach-O port gets matured, we can make a change similar to rL262158: "Remove the old ELF linker."

Diff Detail

Event Timeline

MaskRay created this revision.Mar 4 2020, 2:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 4 2020, 2:48 PM
ruiu added a comment.Mar 4 2020, 6:23 PM

But we are going to call the new one as mach_o2 until mach_o can be removed and rename the new one mach_o once it's done, no? If so, I don't think we need to rename only this part at this moment. We can rename them all at once later.

Sorry, this slipped through the cracks, but I agree with @ruiu .