Page MenuHomePhabricator

[MLIR][Affine][NFC] Remove obsolete and ambiguous definitions
ClosedPublic

Authored by flaub on Mar 3 2020, 4:59 PM.

Details

Summary

Looks like a refactor that was never completed.

This change removes some unused and ambiguous definitions.

Diff Detail

Event Timeline

flaub created this revision.Mar 3 2020, 4:59 PM
Herald added a project: Restricted Project. · View Herald Transcript
bondhugula accepted this revision.Mar 4 2020, 6:14 AM

Thanks very much for cleaning this up. There are really no users for getFlattenedAffineExpr(s) in lib/IR - it's used from under lib/Analysis/, and there is an extended version using AffineExprFlattener there (as opposed to SimpleAffineExprFlattener).

nicolasvasilache accepted this revision.Mar 4 2020, 6:18 AM

Great, thanks @flaub !

rriddle accepted this revision.Mar 4 2020, 10:11 AM
rriddle added inline comments.
mlir/include/mlir/IR/AffineExpr.h
85

Note, if you use git-clang-format it should only format the changes that you've made without touching existing code.

This revision is now accepted and ready to land.Mar 4 2020, 10:11 AM
flaub marked an inline comment as done.Mar 4 2020, 12:19 PM

I tried to use this from outside of MLIR core and it ended up not possible to even call the getFlattendAffineExprs that doesn't take a 3rd argument due to that being ambiguous with the one defined in AffineStructures.

mlir/include/mlir/IR/AffineExpr.h
85

Thanks! I didn't know about this and I'll try to use this in my workflow from now on :)

flaub updated this revision to Diff 248297.Mar 4 2020, 1:08 PM

Use git-clang-format

This revision was automatically updated to reflect the committed changes.