Page MenuHomePhabricator

[test-suite] Add -fcommon
ClosedPublic

Authored by SjoerdMeijer on Mar 3 2020, 12:10 PM.

Details

Summary

D75056 is going change Clang driver defaults from -fcommon to -fno-common. This change had to be reverted because of these failing test cases in the test-suite:

FAIL: MultiSource/Applications/JM/ldecod/ldecod.compile_time (1 of 2630)
FAIL: MultiSource/Applications/JM/lencod/lencod.compile_time (2 of 2630)
FAIL: MultiSource/Benchmarks/ASC_Sequoia/IRSmk/IRSmk.compile_time (3 of 2630)
FAIL: MultiSource/Benchmarks/DOE-ProxyApps-C/miniAMR/miniAMR.compile_time (4 of 2630)
FAIL: MultiSource/Benchmarks/Olden/bh/bh.compile_time (5 of 2630)
FAIL: MultiSource/Benchmarks/Prolangs-C/TimberWolfMC/timberwolfmc.compile_time (6 of 2630)
FAIL: MultiSource/Benchmarks/Prolangs-C/compiler/compiler.compile_time (7 of 2630)
FAIL: MultiSource/Benchmarks/Prolangs-C/loader/loader.compile_time (8 of 2630)
FAIL: MultiSource/Benchmarks/Prolangs-C/simulator/simulator.compile_time (9 of 2630)

which all failed compiling with "multiple definition of .. " link errors as a result of this change. So, this adds -fcommon to the CMake files that need this.

Diff Detail