[clang-format] Fixed BraceWrapping.AfterExternBlock

[MarcusJohnson91]

Clang-Formatted UnwrappedLineParser.cpp

[MarcusJohnson91]

Not sure why it failed to compile, it compiles just fine on my machine...

I'm gonna re-pull from master and see if it works.

Edit: It compiles just fine, even on master

[MarcusJohnson91]

Rewrote the AfterExternBlock code to rely on just that clang-format option and remove the ExternNamespace check.

Fixed the tests as well.

and clang-formatted everything

[MyDeveloperDay]

This needs a full context diff, before we can even look at it properly.

[MarcusJohnson91]

Full Context Diff (I think?)

and the tests pass on my machine, but I'm not 100% sure I set up the testing correctly.

[MarcusJohnson91]

I'm moving the intended change to a new clang-format option instead of modifying an established one.

clang/lib/Format/UnwrappedLineParser.cpp

     if (FormatTok->Tok.is(tok::string_literal)) {
       nextToken();
       if (FormatTok->Tok.is(tok::l_brace)) {
-        if (Style.BraceWrapping.AfterExternBlock &&
-            Style.BraceWrapping.AfterNamespace) {
-          addUnwrappedLine();
+        if (Style.BraceWrapping.AfterExternBlock) {
           parseBlock(/*MustBeDeclaration=*/true);
-        } else if (Style.BraceWrapping.AfterExternBlock &&
-                   Style.BraceWrapping.AfterNamespace == false) {
-          parseBlock(/*MustBeDeclaration=*/false);
         } else {
           parseBlock(/*MustBeDeclaration=*/true, /*AddLevel=*/false);
         }

clang/unittests/Format/FormatTest.cpp

 
   Style.BraceWrapping.AfterExternBlock = true;
   Style.BraceWrapping.SplitEmptyRecord = false;
-  verifyFormat("extern \"C\"\n"
-               "{}",
-               Style);
-  verifyFormat("extern \"C\"\n"
-               "{\n"
+  verifyFormat("extern \"C\" {}", Style);
+  verifyFormat("extern \"C\" {\n"
                "  int foo();\n"
                "}",
                Style);
+
+  Style.BraceWrapping.AfterExternBlock = false;
+  verifyFormat("extern \"C\" {}", Style);
+  verifyFormat("extern \"C\" {\n"
+               "int foo();\n"
+               "}",
+               Style);
 }
 
 TEST_F(FormatTest, FormatsInlineASM) {