- User Since
- Feb 3 2020, 7:37 PM (62 w, 6 d)
Oct 2 2020
It is not entirely clear whether I use the "ARM64" (Apple) or "AArch64" (non-Apple) naming convention. Guidance is appreciated.
Sep 22 2020
Sep 21 2020
After looking more closely at the issue, it seems you're having an issue with Mozilla's comment alignment option.
Sep 20 2020
Aug 8 2020
Hey guys, I'm rebasing and starting work on this again, sorry for the wait I moved 2000 miles from Michigan to Oregon.
May 22 2020
Hey guys: @sivachandra.
May 20 2020
May 19 2020
Format.h: indented the `AfterExternBlock: true` example code snippet with 4 spaces like the Indent option so it's more visible and matches.
Made the IndentExternBlockStyle enum comments a bit clearer, and regenerated the .rst file
Just fixed the formatting of the ReleaseNotes.rst file, the extern blocks were slightly askew, and it might've made it a bit confusing
Ok, I've removed the inherited ones, and also removed the times I was setting a style when there wasn't one before.
May 18 2020
As for crashes, none of them seem relevant; I'm on MacOS, the windows ABI crash seems especially irrelevent.
Added the style initializers, moved IEBS_AfterExternBlock to be the first enum value so that it's zero, that way the bool logic works.
I've initialized all styles to either AfterExternBlock, if there was a BraceWrapping block, or NoIndent if there wasn't.
I've got the indenting to work manually now as well, the issue was you need to have BreakBeforeBraces: Custom in the inline style for it to pick up BraceWrapping.AfterExternBlock's value.
Fixed the generation of ReleaseNotes.rst
May 17 2020
May 16 2020
Removed the lowercase Noindent case, that was a last minute addition I thought might make it a tad easier to work with, but you're right I didn't even test it, and honestly adding that complexity is just pointless at best.
Did everything you asked and did a littl bit of my own cleanup as well.
Removed forgotten comment from control logic of UnwrappedLineParser
I've fixed all of your comments as well as fixed the tests.
Apr 19 2020
Apr 14 2020
but I'm also constantly surprised by how many of the enumeration cases started out as booleans only later to have to be converted to enums. The more I think about this the more I think the problem can probably be dealt with better by making it an enumeration. (even if you support true and false to mean "indent" and "don't indent"
Apr 3 2020
I agree that changing formatting randomly isn't a good idea, and I think converting AfterExternBlock to an enum is the way to go, but I'm just not sure on how it should be implemented.
Mar 31 2020
Mar 25 2020
Implemented the suggestion to break the test strings down into smaller pieces
Mar 24 2020
Restored all the test function names to foo().
Implemented @MyDeveloperDay's suggestion to simplify the if/else statements.
Mar 23 2020
Rebased on Master again, recompiling and re-running all the tests.
Mar 21 2020
Rebased on master
Rebased on master
Mar 18 2020
Mar 14 2020
Fixed Format.h comments, and rebased on master.
Mar 13 2020
I'm refactoring this around wchar (and adding basic wchar support as well)
Mar 12 2020
Fixed a minor clang-format line length issue in the source files, and removed a duplicated cmake entry
Mar 11 2020
Rebased and Squashed Uchar patch
New squashed commit with all changes present
Mar 7 2020
Updated the release notes
Removed the debugging comments I added to FormatTest.cpp
Mar 6 2020
Mar 3 2020
I'm moving the intended change to a new clang-format option instead of modifying an established one.
Mar 1 2020
Full Context Diff (I think?)
Feb 29 2020
Rewrote the AfterExternBlock code to rely on just that clang-format option and remove the ExternNamespace check.
Not sure why it failed to compile, it compiles just fine on my machine...
Feb 8 2020
Added uchar.h.def based on string.h.def, but I don't understand what it's actually doing.
uint_leastX_t -> UINT_LEASTXTYPE__ in char16_t and char32_t typedefs
Removed all of the new calls, starting work on the latest comments
Fixed the header blocks and reformatted
Feb 6 2020
Added trailing newline to CMakeLists
Clang-formatted, and replaced calloc with calls to new, as well as removed ULL from size_t variable initializations