The Vector struct does not require a C++ runtime.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM if you comply with clang-format. (Literally copy-pasting the code should be fine, don't know why you decided to reformat it).
Comment Actions
I did encounter a few cases where my clang-format does not agree with what phab says.
I rebuilt clang at HEAD today and I have:
.../llvm-project$ git-clang-format --binary=./build/bin/clang-format --style=LLVM HEAD^ clang-format did not modify any files
I can manually "fix" the format to make phab happy like I did in the past but I doubt phab is right.
Comment Actions
I rebuilt clang at HEAD today and I have:
I think we are running some stable version of clang-format. @mehdi_amini for more context.