Page MenuHomePhabricator

[CUDA,clang-cl] Filter out unsupported arguments for device-side compilation.
ClosedPublic

Authored by tra on Feb 27 2020, 3:36 PM.

Details

Summary

Device-side compilation does not support some features and we need to
filter them out when command line options enable them for the host.

We're already doing this in various places in the regular clang driver,
but clang-cl mode constructs cc1 options independently and needs to
implement the filtering, too.

Diff Detail

Event Timeline

tra created this revision.Feb 27 2020, 3:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 27 2020, 3:36 PM
rnk accepted this revision.Feb 27 2020, 5:18 PM
rnk added a subscriber: hans.

lgtm, but let us ask @hans for a second opinion.

This revision is now accepted and ready to land.Feb 27 2020, 5:18 PM
hans accepted this revision.Feb 28 2020, 2:45 AM

It seems a little bit unfortunate to have to sprinkle !isNVPTX everywhere, but I don't have any better ideas, so lgtm.

This revision was automatically updated to reflect the committed changes.