This call results in inserting operations that compute the return shape
dynamically for the operation.
Details
Details
- Reviewers
pifon2a
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/include/mlir/Analysis/InferTypeOpInterface.td | ||
---|---|---|
108 | nit: /*methodBody=*/[{}], /*defaultImplementation=*/[{ return failure(); }] | |
mlir/test/lib/TestDialect/TestDialect.cpp | ||
327 | nit: maybe smth like: auto sval = operandType.dyn_cast<ShapedType>(); if (!sval) { return emitOptionalError(location, "only shaped type operands allowed"); } int64_t dim = sval.hasRank() ? sval.getShape().front() : ShapedType::kDynamicSize; | |
328 | just out of curiosity: is reserve() really needed for 1 element? | |
329 | why 17? | |
337 | will smth like that work? shapes = {builder.createOrFold<mlir::DimOp>(getLoc(), getOperand(0), 0)}; |
Comment Actions
Landed in e706533f0a52b2eb8929d4004d1daccd53feda29, removed the review line by accident.
nit: