Page MenuHomePhabricator

Fix/clarify parts of MLIR toy tutorial chaper 4.
ClosedPublic

Authored by matthiaskramm on Feb 27 2020, 7:56 AM.

Details

Summary
  • Let's use "override" when we're just doing standard baseclassing. ("Specialization" makes it sound like template specialization, which this is not.)
  • CallInterfaces.td has an include guard, so #ifdef not needed anymore.
  • Omit duplicate code in code samples.
  • Clarify which algorithm we're talking about.
  • Mention that the ShapeInference code is code a snippet that belongs to algorithm discussed in the paragraph above it.
  • Add missing definition for createShapeInferencePass.

Diff Detail

Event Timeline

matthiaskramm created this revision.Feb 27 2020, 7:56 AM
rriddle accepted this revision.Feb 27 2020, 10:00 AM
This revision is now accepted and ready to land.Feb 27 2020, 10:00 AM

Thanks for the quick review! I don't have write access. Any chance you could submit this? (Same question for the other commits you reviewed?)

This revision was automatically updated to reflect the committed changes.

Thanks for the quick review! I don't have write access. Any chance you could submit this? (Same question for the other commits you reviewed?)

Done. Thank you for all of the fixes!