This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Fix _LIBCPP_HAS_THREAD_API_EXTERNAL build
ClosedPublic

Authored by miyuki on Feb 26 2020, 8:56 AM.

Details

Summary

The definition of __libcpp_timed_backoff_policy and the declaration of
__libcpp_thread_poll_with_backoff must not be guarded by

#if !defined(_LIBCPP_HAS_THREAD_API_EXTERNAL)

because the definitions of __libcpp_timed_backoff_policy::operator()
and __libcpp_thread_poll_with_backoff aren't guarded by this macro
(and this is correct because these two functions are implemented in
terms of other libc++ functions and don't interact with the host
threading library).

Diff Detail

Event Timeline

miyuki created this revision.Feb 26 2020, 8:56 AM
Herald added a project: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Feb 26 2020, 9:51 AM
This revision is now accepted and ready to land.Feb 26 2020, 9:51 AM
This revision was automatically updated to reflect the committed changes.