Page MenuHomePhabricator

[RISCV] Fix sysroot tests without GCC on RISC-V hosts with GCC
ClosedPublic

Authored by luismarques on Feb 24 2020, 9:12 AM.

Details

Summary

D68391 added tests that check scenarios where no RISC-V GCC toolchain is supposed to be detected. When running the tests on RISC-V hosts the system's GCC toolchain will be detected, and the tests will fail. This patch adds a --gcc-toolchain option pointing to a path where no GCC toolchain is present, ensuring that the tests are run under the expected conditions, and therefore are able to pass in all test environments.

(I had also explored the option of checking if the found GCC toolchain actually matched the exact requested triple, but there seems to be no good way of doing that, and the test would still fail if such an exact match happened to be found anyway).

Diff Detail

Event Timeline

luismarques created this revision.Feb 24 2020, 9:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 24 2020, 9:12 AM
edward-jones accepted this revision.Feb 25 2020, 3:26 AM

Looks good to me. Clang tests all pass on my local build.

This revision is now accepted and ready to land.Feb 25 2020, 3:26 AM
This revision was automatically updated to reflect the committed changes.