Page MenuHomePhabricator
Differential D74946

[llvm-objcopy][MachO] Change the storage of sections.
ClosedPublic
Actions

Authored by alexshap on Feb 20 2020, 9:11 PM.

Details

Reviewers
MaskRay
seiya
jhenderson
rupprecht
Commits
rGdc046c70de96: [llvm-objcopy][MachO] Change the storage of sections
Summary

In this diff we change the storage of a section to unique_ptr to avoid pointer invalidation in case of adding/removing new sections.
This refactoring is factored out from D71647.

Test plan: make check-all

Diff Detail

Event Timeline

alexshap created this revision.Feb 20 2020, 9:11 PM
Herald added a reviewer: rupprecht. · View Herald TranscriptFeb 20 2020, 9:11 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: abrachet. · View Herald Transcript
alexshap edited the summary of this revision. (Show Details)Feb 20 2020, 9:12 PM
MaskRay accepted this revision.Feb 20 2020, 9:17 PM
This revision is now accepted and ready to land.Feb 20 2020, 9:17 PM
Closed by commit rGdc046c70de96: [llvm-objcopy][MachO] Change the storage of sections (authored by alexshap). · Explain WhyFeb 21 2020, 1:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
llvm/
tools/
llvm-objcopy/
MachO/
46 lines
32 lines
16 lines
42 lines
4 lines
4 lines

Diff 245981

View Options

llvm/tools/llvm-objcopy/MachO/MachOLayoutBuilder.cpp

Loading...
View Options

llvm/tools/llvm-objcopy/MachO/MachOObjcopy.cpp

Loading...
View Options

llvm/tools/llvm-objcopy/MachO/MachOReader.cpp

Loading...
View Options

llvm/tools/llvm-objcopy/MachO/MachOWriter.cpp

Loading...
View Options

llvm/tools/llvm-objcopy/MachO/Object.h

Loading...
View Options

llvm/tools/llvm-objcopy/MachO/Object.cpp

Loading...