Page MenuHomePhabricator

[OpenCL] Remove spurious atomic_fetch_min/max builtins
ClosedPublic

Authored by svenvh on Feb 20 2020, 9:32 AM.

Details

Summary

These declarations use a mix of unsigned and signed argument and
return types. This is not defined in OpenCL v2.0 s6.13.11.

Diff Detail

Event Timeline

svenvh created this revision.Feb 20 2020, 9:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 20 2020, 9:32 AM

Are you sure this change will not break OpenCL conformance tests? I remember they are there for some reason.

I recall we agreed that conformance tests using mixed types were broken, so this change should be OK. Hopefully this will not affect users.

I would say if we are not aware of any test that this change breaks, let's go ahead and commit this?

yaxunl accepted this revision.Feb 27 2020, 8:15 AM

LGTM. Thanks.

This revision is now accepted and ready to land.Feb 27 2020, 8:15 AM
This revision was automatically updated to reflect the committed changes.