Page MenuHomePhabricator

[WebAssembly] Fix memory bug introduced in 52861809994c
ClosedPublic

Authored by tlively on Feb 19 2020, 3:06 PM.

Details

Summary

The instruction at DefI can sometimes be destroyed by
rematerializeCheapDef, so it should not be used after calling that
function. The fix is to use Insert instead when examining additional
multivalue stackifications. Insert is the address of the new
defining instruction after all moves and rematerializations have taken
place.

Diff Detail

Event Timeline

tlively created this revision.Feb 19 2020, 3:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 19 2020, 3:06 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 19 2020, 3:08 PM
This revision was automatically updated to reflect the committed changes.