Page MenuHomePhabricator

[lldb] Fix version string when using LLDB_REVISION but not LLDB_REPOSITORY
ClosedPublic

Authored by rupprecht on Feb 19 2020, 12:07 PM.

Details

Summary

lldb's format string (line one) is:
lldb version $clang_version ($lldb_repo revision $lldb_revision)

When only using $lldb_revision and not $lldb_repo, this might look like:
lldb version 11 ( revision 12345)
which looks pretty ugly.

Aside: I'm not sure we really need all the different versions since we've moved to the monorepo layout -- I don't think anyone is using different llvm/clang/lldb revisions, are they? We could likely tidy this up further if we knew how people consumed the output of lldb --version.

Diff Detail

Event Timeline

rupprecht created this revision.Feb 19 2020, 12:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 19 2020, 12:07 PM
labath accepted this revision.Feb 19 2020, 11:14 PM

Aside: I'm not sure we really need all the different versions since we've moved to the monorepo layout -- I don't think anyone is using different llvm/clang/lldb revisions, are they?

The standalone build of lldb (and clang) still works, and there are people that use it (some distros build their packages this way, and it's the "official" build method in the swift fork afaik). So, in theory one could build lldb+clang+llvm from three different revisions (but I hope noone actually does that).

This revision is now accepted and ready to land.Feb 19 2020, 11:14 PM
JDevlieghere accepted this revision.Feb 20 2020, 9:42 AM

Aside: I'm not sure we really need all the different versions since we've moved to the monorepo layout -- I don't think anyone is using different llvm/clang/lldb revisions, are they?

The standalone build of lldb (and clang) still works, and there are people that use it (some distros build their packages this way, and it's the "official" build method in the swift fork afaik). So, in theory one could build lldb+clang+llvm from three different revisions (but I hope noone actually does that).

Yup, Swift uses the standalone build.

This revision was automatically updated to reflect the committed changes.