Page MenuHomePhabricator

Add a `%darwin_min_target_with_tls_support` lit substitution.
ClosedPublic

Authored by delcypher on Feb 18 2020, 3:48 PM.

Details

Summary

This substitution expands to the appropriate minimum deployment target
flag where thread local storage (TLS) was first introduced on Darwin
platforms. For all other platforms the substitution expands to an empty
string.

E.g. for macOS the substitution expands to -mmacosx-version-min=10.12

This patch adds support for the substitution (and future substitutions)
by doing a minor refactor and then uses the substitution in the relevant
TSan tests.

rdar://problem/59568956

Diff Detail

Event Timeline

delcypher created this revision.Feb 18 2020, 3:48 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 18 2020, 3:48 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
yln accepted this revision.Feb 19 2020, 1:56 PM

LGTM.

This revision is now accepted and ready to land.Feb 19 2020, 1:56 PM
This revision was automatically updated to reflect the committed changes.