This is an archive of the discontinued LLVM Phabricator instance.

Differential D74719

[libc++] Mark the C++03 version of std::function as deprecated
ClosedPublic

Authored by ldionne on Feb 17 2020, 7:56 AM.

Details

Reviewers
EricWF
mclow.lists
Commits
rGc00871641757: [libc++] Mark the C++03 version of std::function as deprecated
Summary

We want to eventually remove it.

Diff Detail

Event Timeline

ldionne created this revision.Feb 17 2020, 7:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 17 2020, 7:56 AM
Herald added subscribers: libcxx-commits, dexonsmith, jkorous, christof. · View Herald Transcript
Harbormaster completed remote builds in B46639: Diff 244978.Feb 17 2020, 8:00 AM
Herald added a reviewer: mclow.lists. · View Herald TranscriptFeb 17 2020, 8:00 AM
ldionne added a comment.Feb 20 2020, 9:12 AM

Ping @EricWF

EricWF accepted this revision.Feb 23 2020, 3:44 PM

LGTM.

This revision is now accepted and ready to land.Feb 23 2020, 3:44 PM
Closed by commit rGc00871641757: [libc++] Mark the C++03 version of std::function as deprecated (authored by ldionne). · Explain WhyFeb 24 2020, 8:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
libcxx/
include/
15 lines

Diff 246219

libcxx/include/__functional_03

Show First 20 Lines • Show All 437 Lines • ▼ Show 20 Lines
{ {
return typeid(_Fp); return typeid(_Fp);
} }
#endif // _LIBCPP_NO_RTTI #endif // _LIBCPP_NO_RTTI
} // __function } // __function
#if !defined(_LIBCPP_DISABLE_DEPRECATION_WARNINGS) && __has_attribute(deprecated)
# define _LIBCPP_DEPRECATED_CXX03_FUNCTION \
__attribute__((deprecated("Using std::function in C++03 is not supported anymore. Please upgrade to C++11 or later, or use a different type")))
#else
# define _LIBCPP_DEPRECATED_CXX03_FUNCTION /* nothing */
#endif
template<class _Rp> template<class _Rp>
class _LIBCPP_TEMPLATE_VIS function<_Rp()> class _LIBCPP_DEPRECATED_CXX03_FUNCTION _LIBCPP_TEMPLATE_VIS function<_Rp()>
{ {
typedef __function::__base<_Rp()> __base; typedef __function::__base<_Rp()> __base;
aligned_storage<3*sizeof(void*)>::type __buf_; aligned_storage<3*sizeof(void*)>::type __buf_;
__base* __f_; __base* __f_;
public: public:
typedef _Rp result_type; typedef _Rp result_type;
▲ Show 20 Lines • Show All 262 Lines • ▼ Show 20 Linesfunction<_Rp()>::target() const
if (__f_ == 0) if (__f_ == 0)
return (const _Tp*)0; return (const _Tp*)0;
return (const _Tp*)__f_->target(typeid(_Tp)); return (const _Tp*)__f_->target(typeid(_Tp));
} }
#endif // _LIBCPP_NO_RTTI #endif // _LIBCPP_NO_RTTI
template<class _Rp, class _A0> template<class _Rp, class _A0>
class _LIBCPP_TEMPLATE_VIS function<_Rp(_A0)> class _LIBCPP_DEPRECATED_CXX03_FUNCTION _LIBCPP_TEMPLATE_VIS function<_Rp(_A0)>
: public unary_function<_A0, _Rp> : public unary_function<_A0, _Rp>
{ {
typedef __function::__base<_Rp(_A0)> __base; typedef __function::__base<_Rp(_A0)> __base;
aligned_storage<3*sizeof(void*)>::type __buf_; aligned_storage<3*sizeof(void*)>::type __buf_;
__base* __f_; __base* __f_;
public: public:
typedef _Rp result_type; typedef _Rp result_type;
▲ Show 20 Lines • Show All 263 Lines • ▼ Show 20 Linesfunction<_Rp(_A0)>::target() const
if (__f_ == 0) if (__f_ == 0)
return (const _Tp*)0; return (const _Tp*)0;
return (const _Tp*)__f_->target(typeid(_Tp)); return (const _Tp*)__f_->target(typeid(_Tp));
} }
#endif // _LIBCPP_NO_RTTI #endif // _LIBCPP_NO_RTTI
template<class _Rp, class _A0, class _A1> template<class _Rp, class _A0, class _A1>
class _LIBCPP_TEMPLATE_VIS function<_Rp(_A0, _A1)> class _LIBCPP_DEPRECATED_CXX03_FUNCTION _LIBCPP_TEMPLATE_VIS function<_Rp(_A0, _A1)>
: public binary_function<_A0, _A1, _Rp> : public binary_function<_A0, _A1, _Rp>
{ {
typedef __function::__base<_Rp(_A0, _A1)> __base; typedef __function::__base<_Rp(_A0, _A1)> __base;
aligned_storage<3*sizeof(void*)>::type __buf_; aligned_storage<3*sizeof(void*)>::type __buf_;
__base* __f_; __base* __f_;
public: public:
typedef _Rp result_type; typedef _Rp result_type;
▲ Show 20 Lines • Show All 263 Lines • ▼ Show 20 Linesfunction<_Rp(_A0, _A1)>::target() const
if (__f_ == 0) if (__f_ == 0)
return (const _Tp*)0; return (const _Tp*)0;
return (const _Tp*)__f_->target(typeid(_Tp)); return (const _Tp*)__f_->target(typeid(_Tp));
} }
#endif // _LIBCPP_NO_RTTI #endif // _LIBCPP_NO_RTTI
template<class _Rp, class _A0, class _A1, class _A2> template<class _Rp, class _A0, class _A1, class _A2>
class _LIBCPP_TEMPLATE_VIS function<_Rp(_A0, _A1, _A2)> class _LIBCPP_DEPRECATED_CXX03_FUNCTION _LIBCPP_TEMPLATE_VIS function<_Rp(_A0, _A1, _A2)>
{ {
typedef __function::__base<_Rp(_A0, _A1, _A2)> __base; typedef __function::__base<_Rp(_A0, _A1, _A2)> __base;
aligned_storage<3*sizeof(void*)>::type __buf_; aligned_storage<3*sizeof(void*)>::type __buf_;
__base* __f_; __base* __f_;
public: public:
typedef _Rp result_type; typedef _Rp result_type;
▲ Show 20 Lines • Show All 297 Lines • Show Last 20 Lines