Page MenuHomePhabricator

Remove "ELF Only" restriction from section flags
ClosedPublic

Authored by rnk on Feb 14 2020, 11:48 AM.

Details

Summary

-ffunction-sections and -fdata-sections are well supported by many
object file formats:

  • ELF
  • COFF
  • XCOFF
  • wasm

Only MachO ignores this flag.

While here, remove it from -funique-section-names. Wasm honors this
option.

Addresses PR44910.

Diff Detail

Event Timeline

rnk created this revision.Feb 14 2020, 11:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2020, 11:48 AM
This revision is now accepted and ready to land.Feb 14 2020, 11:31 PM
hans accepted this revision.Feb 17 2020, 2:45 AM

In the commit message, which is currently "Remove "ELF Only" restriction from section flags" maybe add "help text" or something to make it obvious this only changes the help text -- i.e. it's not removing any actual "elf only" restriction.

This revision was automatically updated to reflect the committed changes.