llvm: Use quotes around MSVC_DIA_SDK_DIR CMake variable

[cristian.adam]

Summary

MSVC_DIA_SDK_DIR variable will point to a path which contains spaces, and without quotes it will fail to configure the project.

[mstorsjo]

LGTM

[cristian.adam]

I do not have commit rights, I need help to submit this patch.

[mstorsjo]

I can try to get it committed soon. What form do you want for the author line, "Cristian Adam <[e-mail]>"?

[cristian.adam]

In D74561#1880310, @mstorsjo wrote:

I can try to get it committed soon. What form do you want for the author line, "Cristian Adam <[e-mail]>"?

That's good. Thank you.

[cristian.adam]

This could also be cherry-picked for release/10.x. Would close https://bugs.llvm.org/show_bug.cgi?id=44906

[mstorsjo]

Committed in d6fe253653b7e760f94ca21d0a7ebbfeeee28777 (I forgot the Differential Revision: tag, sorry).

@hans - this would be a safe backport to 10.x.

[hans]

In D74561#1880418, @mstorsjo wrote:

Committed in d6fe253653b7e760f94ca21d0a7ebbfeeee28777 (I forgot the Differential Revision: tag, sorry).

@hans - this would be a safe backport to 10.x.

Pushed as 3dee8be1c3fe621b9c1926658f6c0df72ce804be. Thanks!

[mstorsjo]

Committed and backported. Thanks!

llvm/cmake/config-ix.cmake

   # though that we should handle it.  We do so by simply checking that
   # the DIA SDK folder exists.  Should this happen you will need to
   # uninstall VS 2012 and then re-install VS 2013.
-  if (IS_DIRECTORY ${MSVC_DIA_SDK_DIR})
+  if (IS_DIRECTORY "${MSVC_DIA_SDK_DIR}")
     set(HAVE_DIA_SDK 1)
   else()
     set(HAVE_DIA_SDK 0)