This is an archive of the discontinued LLVM Phabricator instance.

[mlir] [VectorOps] Initial framework for progressively lowering vector.contract
ClosedPublic

Authored by aartbik on Feb 12 2020, 7:13 PM.

Details

Summary

This sets the basic framework for lowering vector.contract progressively
into simpler vector.contract operations until a direct vector.reduction
operation is reached. More details will be filled out progressively as well.

Diff Detail

Event Timeline

aartbik created this revision.Feb 12 2020, 7:13 PM
nicolasvasilache accepted this revision.Feb 13 2020, 2:33 PM

Minor nits, approving conditionally.
Thanks Aart!

mlir/lib/Dialect/VectorOps/VectorOps.cpp
364 ↗(On Diff #244320)

trivial braces

373 ↗(On Diff #244320)

trivial braces

mlir/test/lib/Transforms/TestVectorTransforms.cpp
55–56

lowerCamelCase names here and below plz.
It seems we missed a beat with slicesPass in the past.

This revision is now accepted and ready to land.Feb 13 2020, 2:33 PM
aartbik updated this revision to Diff 244540.Feb 13 2020, 2:55 PM
aartbik marked 3 inline comments as done.

addressed comments, rebased

This revision was automatically updated to reflect the committed changes.