This sets the basic framework for lowering vector.contract progressively
into simpler vector.contract operations until a direct vector.reduction
operation is reached. More details will be filled out progressively as well.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Minor nits, approving conditionally.
Thanks Aart!
mlir/lib/Dialect/VectorOps/VectorOps.cpp | ||
---|---|---|
364 ↗ | (On Diff #244320) | trivial braces |
373 ↗ | (On Diff #244320) | trivial braces |
mlir/test/lib/Transforms/TestVectorTransforms.cpp | ||
55–56 | lowerCamelCase names here and below plz. |
lowerCamelCase names here and below plz.
It seems we missed a beat with slicesPass in the past.