Page MenuHomePhabricator

clang: Treat ieee mode as the default for denormal-fp-math
ClosedPublic

Authored by arsenm on Feb 12 2020, 1:03 PM.

Details

Summary

The IR hasn't switched the default yet, so explicitly add the ieee attributes.

I'm still not really sure how the target default denormal mode should
interact with -fno-unsafe-math-optimizations. The target may have
selected the default mode to be non-IEEE based on the flags or based
on its true behavior, but we don't know which is the case. Since the
only users of a non-IEEE mode without a flag still support IEEE mode,
just reset to IEEE.

Diff Detail

Event Timeline

arsenm created this revision.Feb 12 2020, 1:03 PM
arsenm updated this revision to Diff 245972.Feb 21 2020, 1:11 PM
arsenm edited the summary of this revision. (Show Details)

Rebase

spatel added inline comments.Mar 2 2020, 10:42 AM
llvm/include/llvm/ADT/FloatingPointMode.h
48 ↗(On Diff #245972)

Can these constexpr diffs be separated out as an NFC preliminary commit?

arsenm updated this revision to Diff 248349.Mar 4 2020, 3:48 PM

Split out constexpr change

This revision is now accepted and ready to land.Mar 4 2020, 5:42 PM