Add '#include <functional>` to PassManager.h.

[pifon2a]

Summary

On some platforms the build fails "std::function is not found". The include is used in PassManager::IRPrinterConfig::enableIRPrinting.

[herhut]

include files for the win :-)

Thanks for fixing.

[rriddle]

This description doesn't make sense. PassPipelineRegistration is defined in PassRegistry.h which already includes functional. The only place that uses std::function in PassManager.h is enableIRPrinting. Can you update the description?

[pifon2a]

Update the description.

[rriddle]

Thanks for the fix! I'm surprised we just now ran into this.

mlir/include/mlir/Pass/PassManager.h

 //===- PassManager.h - Pass Management Interface ----------------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 #ifndef MLIR_PASS_PASSMANAGER_H
 #define MLIR_PASS_PASSMANAGER_H
 
 #include "mlir/Support/LogicalResult.h"
 #include "llvm/ADT/Optional.h"
 #include "llvm/ADT/SmallVector.h"
 #include "llvm/ADT/iterator.h"
 
+#include <functional>
 #include <vector>
 
 namespace llvm {
 class Any;
 } // end namespace llvm
 
 namespace mlir {
 class AnalysisManager;