Page MenuHomePhabricator

Add '#include <functional>` to PassManager.h.
ClosedPublic

Authored by pifon2a on Feb 12 2020, 1:13 AM.

Details

Summary

On some platforms the build fails "std::function is not found". The include is used in PassManager::IRPrinterConfig::enableIRPrinting.

Diff Detail

Event Timeline

pifon2a created this revision.Feb 12 2020, 1:13 AM
Herald added a project: Restricted Project. · View Herald Transcript
herhut accepted this revision.Feb 12 2020, 2:25 AM

include files for the win :-)

Thanks for fixing.

rriddle requested changes to this revision.Feb 12 2020, 9:40 AM

This description doesn't make sense. PassPipelineRegistration is defined in PassRegistry.h which already includes functional. The only place that uses std::function in PassManager.h is enableIRPrinting. Can you update the description?

This revision now requires changes to proceed.Feb 12 2020, 9:40 AM
pifon2a updated this revision to Diff 244335.Feb 12 2020, 10:23 PM

Update the description.

pifon2a edited the summary of this revision. (Show Details)Feb 12 2020, 10:24 PM
rriddle accepted this revision.Feb 12 2020, 10:26 PM

Thanks for the fix! I'm surprised we just now ran into this.

This revision is now accepted and ready to land.Feb 12 2020, 10:26 PM
This revision was automatically updated to reflect the committed changes.