This is an archive of the discontinued LLVM Phabricator instance.

Differential D74421

[mlir] Linalg fusion: ignore indexed_generic producers
ClosedPublic

Authored by ftynse on Feb 11 2020, 9:53 AM.

Details

Reviewers
nicolasvasilache
Summary

They are currently not supported and we should not attempt fusing them.

Diff Detail

Unit TestsFailed

TimeTest
2,040 mslibc++.std/thread/thread_mutex/thread_mutex_requirements/thread_mutex_requirements_mutex/thread_mutex_recursive::Unknown Unit Message ("")

Event Timeline

ftynse created this revision.Feb 11 2020, 9:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 11 2020, 9:53 AM
Herald added subscribers: llvm-commits, Joonsoo, liufengdb and 10 others. · View Herald Transcript
nicolasvasilache accepted this revision.Feb 11 2020, 9:54 AM
This revision is now accepted and ready to land.Feb 11 2020, 9:54 AM
Harbormaster failed remote builds in B46240: Diff 243906!Feb 11 2020, 10:32 AM
ftynse updated this revision to Diff 244153.Feb 12 2020, 6:08 AM

Add test

ftynse closed this revision.Feb 12 2020, 6:15 AM

Landed 5ae9c4c86806811cab3735dd56237ec1a9614354

Revision Contents

PathSize
mlir/
lib/
Dialect/
Linalg/
Transforms/
4 lines

Diff 243906

mlir/lib/Dialect/Linalg/Transforms/Fusion.cpp

Show First 20 Lines • Show All 272 Lines • ▼ Show 20 Lines assert(consumer.hasBufferSemantics() &&
"expected linalg op with buffer semantics"); "expected linalg op with buffer semantics");
LLVM_DEBUG(dbgs() << "\nStart examining consumer: " LLVM_DEBUG(dbgs() << "\nStart examining consumer: "
<< *consumer.getOperation()); << *consumer.getOperation());
for (auto dependence : graph.getDependencesInto( for (auto dependence : graph.getDependencesInto(
consumer, LinalgDependenceGraph::DependenceType::RAW)) { consumer, LinalgDependenceGraph::DependenceType::RAW)) {
LLVM_DEBUG(dbgs() << "\n***Consider producer:\t" LLVM_DEBUG(dbgs() << "\n***Consider producer:\t"
<< *dependence.dependentOpView.op << "\n"); << *dependence.dependentOpView.op << "\n");
auto producer = cast<LinalgOp>(dependence.dependentOpView.op); auto producer = cast<LinalgOp>(dependence.dependentOpView.op);
if (isa<linalg::IndexedGenericOp>(dependence.dependentOpView.op)) {
LLVM_DEBUG(dbgs() << "Not fusing indexed_generic producer");
continue;
}
// Check that the dependence is indeed on the input `consumerIdx` view. // Check that the dependence is indeed on the input `consumerIdx` view.
auto consumedView = dependence.indexingView; auto consumedView = dependence.indexingView;
if (consumer.getInput(consumerIdx) != consumedView) if (consumer.getInput(consumerIdx) != consumedView)
continue; continue;
// Consumer consumes this view, `isStructurallyFusableProducer` also checks // Consumer consumes this view, `isStructurallyFusableProducer` also checks
// whether it is a strict subview of the producer view. // whether it is a strict subview of the producer view.
▲ Show 20 Lines • Show All 275 Lines • Show Last 20 Lines