This is an archive of the discontinued LLVM Phabricator instance.

Differential D74259

[WebAssembly] Add cbrt function signatures
ClosedPublic

Authored by tlively on Feb 7 2020, 3:03 PM.

Details

Reviewers
aheejin
Commits
rGe252293d0629: [WebAssembly] Add cbrt function signatures
Summary

Fixes a crash in the backend where optimizations produce calls to the
cbrt runtime functions. Fixes PR 44227.

Diff Detail

Event Timeline

tlively created this revision.Feb 7 2020, 3:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 7 2020, 3:03 PM
Herald added subscribers: llvm-commits, sunfish, hiraditya and 3 others. · View Herald Transcript
Harbormaster completed remote builds in B45986: Diff 243294.Feb 7 2020, 3:20 PM
aheejin accepted this revision.Feb 7 2020, 8:01 PM
This revision is now accepted and ready to land.Feb 7 2020, 8:01 PM
Closed by commit rGe252293d0629: [WebAssembly] Add cbrt function signatures (authored by tlively). · Explain WhyFeb 13 2020, 1:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
lib/
Target/
WebAssembly/
3 lines
test/
CodeGen/
WebAssembly/
6 lines

Diff 244524

llvm/lib/Target/WebAssembly/WebAssemblyRuntimeLibcallSignatures.cpp

Show First 20 Lines • Show All 172 Lines • ▼ Show 20 Lines RuntimeLibcallSignatureTable() : Table(RTLIB::UNKNOWN_LIBCALL, unsupported) {
Table[RTLIB::FMA_F64] = f64_func_f64_f64_f64; Table[RTLIB::FMA_F64] = f64_func_f64_f64_f64;
Table[RTLIB::FMA_F128] = func_iPTR_i64_i64_i64_i64_i64_i64; Table[RTLIB::FMA_F128] = func_iPTR_i64_i64_i64_i64_i64_i64;
Table[RTLIB::POWI_F32] = f32_func_f32_i32; Table[RTLIB::POWI_F32] = f32_func_f32_i32;
Table[RTLIB::POWI_F64] = f64_func_f64_i32; Table[RTLIB::POWI_F64] = f64_func_f64_i32;
Table[RTLIB::POWI_F128] = func_iPTR_i64_i64_i32; Table[RTLIB::POWI_F128] = func_iPTR_i64_i64_i32;
Table[RTLIB::SQRT_F32] = f32_func_f32; Table[RTLIB::SQRT_F32] = f32_func_f32;
Table[RTLIB::SQRT_F64] = f64_func_f64; Table[RTLIB::SQRT_F64] = f64_func_f64;
Table[RTLIB::SQRT_F128] = func_iPTR_i64_i64; Table[RTLIB::SQRT_F128] = func_iPTR_i64_i64;
Table[RTLIB::CBRT_F32] = f32_func_f32;
Table[RTLIB::CBRT_F64] = f64_func_f64;
Table[RTLIB::CBRT_F128] = func_iPTR_i64_i64;
Table[RTLIB::LOG_F32] = f32_func_f32; Table[RTLIB::LOG_F32] = f32_func_f32;
Table[RTLIB::LOG_F64] = f64_func_f64; Table[RTLIB::LOG_F64] = f64_func_f64;
Table[RTLIB::LOG_F128] = func_iPTR_i64_i64; Table[RTLIB::LOG_F128] = func_iPTR_i64_i64;
Table[RTLIB::LOG2_F32] = f32_func_f32; Table[RTLIB::LOG2_F32] = f32_func_f32;
Table[RTLIB::LOG2_F64] = f64_func_f64; Table[RTLIB::LOG2_F64] = f64_func_f64;
Table[RTLIB::LOG2_F128] = func_iPTR_i64_i64; Table[RTLIB::LOG2_F128] = func_iPTR_i64_i64;
Table[RTLIB::LOG10_F32] = f32_func_f32; Table[RTLIB::LOG10_F32] = f32_func_f32;
Table[RTLIB::LOG10_F64] = f64_func_f64; Table[RTLIB::LOG10_F64] = f64_func_f64;
▲ Show 20 Lines • Show All 713 Lines • Show Last 20 Lines

llvm/test/CodeGen/WebAssembly/libcalls.ll

Show First 20 Lines • Show All 67 Lines • ▼ Show 20 Lines
; CHECK: f64.call $push{{[0-9]}}=, pow ; CHECK: f64.call $push{{[0-9]}}=, pow
%c = call double @llvm.pow.f64(double %b, double %y) %c = call double @llvm.pow.f64(double %b, double %y)
; CHECK: f64.call $push{{[0-9]}}=, __powidf2 ; CHECK: f64.call $push{{[0-9]}}=, __powidf2
%d = call double @llvm.powi.f64(double %c, i32 %z) %d = call double @llvm.powi.f64(double %c, i32 %z)
; CHECK: f64.call $push{{[0-9]}}=, log ; CHECK: f64.call $push{{[0-9]}}=, log
%e = call double @llvm.log.f64(double %d) %e = call double @llvm.log.f64(double %d)
; CHECK: f64.call $push{{[0-9]}}=, exp ; CHECK: f64.call $push{{[0-9]}}=, exp
%f = call double @llvm.exp.f64(double %e) %f = call double @llvm.exp.f64(double %e)
; CHECK: f64.call $push{{[0-9]}}=, cbrt
%g = call fast double @llvm.pow.f64(double %f, double 0x3FD5555555555555)
; CHECK: i32.call $push{{[0-9]}}=, lround ; CHECK: i32.call $push{{[0-9]}}=, lround
%g = call i32 @llvm.lround(double %f) %h = call i32 @llvm.lround(double %g)
ret i32 %g ret i32 %h
} }
; fcmp ord and unord (RTLIB::O_F32 / RTLIB::UO_F32 etc) are a special case (see ; fcmp ord and unord (RTLIB::O_F32 / RTLIB::UO_F32 etc) are a special case (see
; comment in WebAssemblyRunimeLibcallSignatures.cpp) so check them separately. ; comment in WebAssemblyRunimeLibcallSignatures.cpp) so check them separately.
; no libcalls are needed for f32 and f64 ; no libcalls are needed for f32 and f64
; CHECK-LABEL: unordd: ; CHECK-LABEL: unordd:
define i1 @unordd(double %x, double %y) { define i1 @unordd(double %x, double %y) {
Show All 40 Lines