Page MenuHomePhabricator

[llvm-exegesis] Improve error reporting in BenchmarkRunner.cpp
ClosedPublic

Authored by mstojanovic on Feb 7 2020, 4:41 AM.

Details

Summary

Followup to D74085.
Replace the use of report_fatal_error() with returning the error to llvm-exegesis.cpp and handling it there.
To facilitate this, a new Error type has been added which is only used to log errors to the yaml output.

Diff Detail

Event Timeline

mstojanovic created this revision.Feb 7 2020, 4:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 7 2020, 4:41 AM
Herald added a subscriber: tschuett. · View Herald Transcript
courbet accepted this revision.Feb 7 2020, 5:01 AM
courbet added inline comments.
llvm/tools/llvm-exegesis/lib/Error.h
65

please run clang-format on the patch.

This revision is now accepted and ready to land.Feb 7 2020, 5:01 AM

Formatted patch.

This revision was automatically updated to reflect the committed changes.