This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/GlobalISel: Fix mapping G_ICMP with constrained result
ClosedPublic

Authored by arsenm on Feb 6 2020, 4:48 PM.

Details

Reviewers
nhaehnle
kerbowa
Summary

When SI_IF is inserted, it constrains the source register with a
register class, which was quite likely a G_ICMP. This was incorrectly
treating it as a scalar, and then applyMappingImpl would end up
producing invalid MIR since this was unexpected.

Also fix not using all VGPR sources for vcc outputs.

Diff Detail

Event Timeline

arsenm created this revision.Feb 6 2020, 4:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 6 2020, 4:48 PM
kerbowa accepted this revision.Feb 12 2020, 3:03 PM

LGTM

This revision is now accepted and ready to land.Feb 12 2020, 3:03 PM