This is an archive of the discontinued LLVM Phabricator instance.

Differential D74160

[lldb] removed no longer needed CMakeDependentOption
ClosedPublic

Authored by kwk on Feb 6 2020, 1:22 PM.

Details

Reviewers
JDevlieghere
labath
Commits
rGb89131cdda58: [lldb] removed no longer needed CMakeDependentOption
Summary

In D66791 I've introduced this [[ https://cmake.org/cmake/help/latest/module/CMakeDependentOption.html | CMakeDependentOption ]] but in
D71306 @JDevlieghere has changed the way optional dependencies
are handled in LLDB. Today there's no occurence of
cmake_dependent_option inside the lldb source tree.

That's why this include can be removed.

Diff Detail

Event Timeline

kwk created this revision.Feb 6 2020, 1:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 6 2020, 1:22 PM
Herald added subscribers: lldb-commits, mgorny. · View Herald Transcript
kwk updated this revision to Diff 242991.Feb 6 2020, 1:23 PM

Removed typo in commit message

kwk edited the summary of this revision. (Show Details)Feb 6 2020, 1:23 PM
kwk edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B45888: Diff 242990.Feb 6 2020, 1:29 PM
Harbormaster completed remote builds in B45889: Diff 242991.
labath accepted this revision.Feb 6 2020, 1:34 PM
labath added a subscriber: labath.

ship it

This revision is now accepted and ready to land.Feb 6 2020, 1:34 PM
Closed by commit rGb89131cdda58: [lldb] removed no longer needed CMakeDependentOption (authored by kwk). · Explain WhyFeb 7 2020, 12:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lldb/
cmake/
modules/
1 line

Diff 243093

lldb/cmake/modules/LLDBConfig.cmake

include(CheckCXXSymbolExists) include(CheckCXXSymbolExists)
include(CheckTypeSize) include(CheckTypeSize)
include(CMakeDependentOption)
set(LLDB_PROJECT_ROOT ${CMAKE_CURRENT_SOURCE_DIR}) set(LLDB_PROJECT_ROOT ${CMAKE_CURRENT_SOURCE_DIR})
set(LLDB_SOURCE_ROOT "${CMAKE_CURRENT_SOURCE_DIR}/source") set(LLDB_SOURCE_ROOT "${CMAKE_CURRENT_SOURCE_DIR}/source")
set(LLDB_INCLUDE_ROOT "${CMAKE_CURRENT_SOURCE_DIR}/include") set(LLDB_INCLUDE_ROOT "${CMAKE_CURRENT_SOURCE_DIR}/include")
set(LLDB_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}) set(LLDB_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR})
set(LLDB_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}) set(LLDB_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR})
▲ Show 20 Lines • Show All 307 Lines • Show Last 20 Lines