Page MenuHomePhabricator

[mlir] Accept an LLVM::LLVMFuncOp in the builder of LLVM::CallOp
ClosedPublic

Authored by ftynse on Mon, Feb 3, 7:51 AM.

Details

Summary

Replace the generic zero- and one-result builders in LLVM::CallOp with a custom
builder that takes an LLVMFuncOp, which can be used to extract the result type
and create the symbol reference attribute. This is merely a convenience for
upcoming changes. The ODS-generated builders remain present.

Introduce LLVM::LLVMType::isVoidTy by analogy with the underlying LLVM type.

Diff Detail

Event Timeline

ftynse created this revision.Mon, Feb 3, 7:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptMon, Feb 3, 7:51 AM

Unit tests: fail. 62357 tests passed, 1 failed and 839 were skipped.

failed: libc++.std/containers/sequences/array/array_creation/to_array.fail.cpp

clang-tidy: pass.

clang-format: fail. Please format your changes with clang-format by running git-clang-format HEAD^ or applying this patch.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

rriddle accepted this revision.Mon, Feb 3, 9:46 AM

Please fix the clang format issues before landing.

This revision is now accepted and ready to land.Mon, Feb 3, 9:46 AM
This revision was automatically updated to reflect the committed changes.