This is an archive of the discontinued LLVM Phabricator instance.

[Alignment][NFC] Use Align for code creating MemOp
ClosedPublic

Authored by gchatelet on Feb 3 2020, 4:10 AM.

Details

Summary

This is patch is part of a series to introduce an Alignment type.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
See this patch for the introduction of the type: https://reviews.llvm.org/D64790

Event Timeline

gchatelet created this revision.Feb 3 2020, 4:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 3 2020, 4:10 AM
courbet accepted this revision.Feb 3 2020, 4:19 AM
courbet added inline comments.
llvm/include/llvm/CodeGen/TargetLowering.h
113

Why not use an Align as storage ?

llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp
996–998

Align NewAlign = DL.getABITypeAlign() ?

1113

ditto

1218

ditto

llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
5924

ditto

6104–6105

ditto

6203–6204

ditto

This revision is now accepted and ready to land.Feb 3 2020, 4:19 AM
gchatelet updated this revision to Diff 242034.Feb 3 2020, 5:09 AM
gchatelet marked 9 inline comments as done.
  • Address comments
llvm/include/llvm/CodeGen/TargetLowering.h
113

I will in a follow up patch but doing so here will also pull all the downstream changes (parts of the code that uses the MemOp members )

llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp
996–998

Of course!

This revision was automatically updated to reflect the committed changes.