Page MenuHomePhabricator

[MLIR][Linalg] Use GenericLoopNestRangeBuilder in tiling code.
ClosedPublic

Authored by pifon2a on Feb 3 2020, 4:04 AM.

Details

Summary

Preparation for adding support for tiling to parallel loops.

Diff Detail

Event Timeline

pifon2a created this revision.Feb 3 2020, 4:04 AM

Unit tests: pass. 62414 tests passed, 0 failed and 839 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

herhut accepted this revision.Feb 3 2020, 4:52 AM

Looks good to me. I wonder about users of TiledLinAlgOp. Are there none? This should be a breaking change.

@nicolasvasilache should take a look, too.

This revision is now accepted and ready to land.Feb 3 2020, 4:52 AM

Glanced over quickly, looks innocuous enough to me an a good step towards allow generalization to affine, various ploops (affine or not).
If all tests pass (i.e. the check-mlir target), then go for it, we'll adapt if any issues comes up.

Thanks for doing this generalization effort.

This revision was automatically updated to reflect the committed changes.