Page MenuHomePhabricator

[LLDB] Add missing declarations for linking to psapi
ClosedPublic

Authored by mstorsjo on Feb 1 2020, 1:08 PM.

Details

Summary

This fixes building for mingw with BUILD_SHARED_LIBS. In static builds, the psapi dependency gets linked in transitively from Support, but when linking Support dynamically, it's revealed that these components also need linking against psapi.

Diff Detail

Event Timeline

mstorsjo created this revision.Feb 1 2020, 1:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2020, 1:08 PM
Herald added a subscriber: mgorny. · View Herald Transcript
labath accepted this revision.Feb 3 2020, 12:43 AM
This revision is now accepted and ready to land.Feb 3 2020, 12:43 AM
This revision was automatically updated to reflect the committed changes.

I guess this is causing the windows failure on the bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13320

Yeah, I saw that - highly strange. I'll try to see if I can reproduce similar issues with a similar toolchain, and I'll push a revert soon unless I find some great clue.

Seems like this was nondeterministic? http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13321 Maybe a dependency issue on the tblgen.exe...

I guess this is causing the windows failure on the bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13320

Yeah, I saw that - highly strange. I'll try to see if I can reproduce similar issues with a similar toolchain, and I'll push a revert soon unless I find some great clue.

The issue seems to have vanished in the following build, http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13321, and I built a lldb-tblgen.exe using a fairly new version of MSVC, and that didn't seem to have the same issue ("This version of lldb-tblgen.exe is not compatible with the version of Windows you're running."). And the changes I pushed here shouldn't even affect the build of lldb-tblgen.exe at all. So I'd consider this just a coincidence/fluke for now.