[DebugInfo][test] Adjust line table unit length to account for contents

[jhenderson]

Summary

Previously, if a debug line Prologue was created via createBasicPrologue, its TotalLength field did not account for any contents in the table itself. This change fixes this issue.

[probinson]

LGTM.

[jhenderson]

llvm/unittests/DebugInfo/DWARF/DwarfGenerator.cpp

178

Oops, this is incorrect. Contents is not a vector of bytes of data, but rather of ValueAndLength entries, which potentially represent different numbers of bytes. I'll post a fix.

[jhenderson]

llvm/unittests/DebugInfo/DWARF/DwarfGenerator.cpp

178

I'll post a fix.

See D73901.

llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp

TEST_F(DebugLineBasicFixture, ErrorForUnitLengthTooLarge) {
   LineTable &Padding = Gen->addLineTable();
   // Add some padding to show that a non-zero offset is handled correctly.
   Padding.setCustomPrologue({{0, LineTable::Byte}});
   LineTable &LT = Gen->addLineTable();
   LT.addStandardOpcode(DW_LNS_copy, {});
   LT.addStandardOpcode(DW_LNS_const_add_pc, {});
   LT.addExtendedOpcode(1, DW_LNE_end_sequence, {});
   DWARFDebugLine::Prologue Prologue = LT.createBasicPrologue();
-  // Set the total length to 1 higher than the actual length. The program body
-  // has size 5.
-  Prologue.TotalLength += 6;
+  // Set the total length to 1 higher than the actual length.
+  ++Prologue.TotalLength;
   LT.setPrologue(Prologue);
 
   generate();
 
   auto ExpectedLineTable = Line.getOrParseLineTable(LineData, 1, *Context,
                                                     nullptr, RecordRecoverable);
   checkError("line table program with offset 0x00000001 has length 0x00000034 "
              "but only 0x00000033 bytes are available",

llvm/unittests/DebugInfo/DWARF/DwarfGenerator.cpp

case 5:
     break;
   default:
     llvm_unreachable("unsupported version");
   }
   if (Format == DWARF64) {
     P.TotalLength += 4;
     P.FormParams.Format = DWARF64;
   }
+  P.TotalLength += Contents.size();
   P.FormParams.Version = Version;
   P.MinInstLength = 1;
   P.MaxOpsPerInst = 1;
   P.DefaultIsStmt = 1;
   P.LineBase = -5;
   P.LineRange = 14;
   P.OpcodeBase = 13;
   P.StandardOpcodeLengths = {0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1};