Page MenuHomePhabricator

[InstCombine] Rename worklist methods; NFC
ClosedPublic

Authored by nikic on Jan 30 2020, 2:10 PM.

Details

Summary

This renames Worklist.AddDeferred() to Worklist.add() and Worklist.Add() to Worklist.push(). The intention here is that Worklist.add() should be the go-to method for explicit worklist management, while the raw Worklist.push() is mostly for InstCombine internals. I will then migrate uses of Worklist.push() to Worklist.add() in followup changes.

Also happy to switch this to other names if these aren't good.

As suggested by @spatel on D73411 I'm also changing the remaining method names to lowercase first character, in line with current coding standards.

Diff Detail

Event Timeline

nikic created this revision.Jan 30 2020, 2:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 30 2020, 2:10 PM
spatel accepted this revision.Feb 2 2020, 1:49 PM

LGTM

This revision is now accepted and ready to land.Feb 2 2020, 1:49 PM
This revision was automatically updated to reflect the committed changes.