This is an archive of the discontinued LLVM Phabricator instance.

Differential D73631

[scudo] Skip building scudo standalone if sys/auxv.h can't be found
ClosedPublic

Authored by bjope on Jan 29 2020, 8:23 AM.

Details

Reviewers
pcc
cryptoad
Commits
rGf4ca2ac8225e: [scudo] Skip building scudo standalone if sys/auxv.h can't be found
Summary

Since commit c299d1981deaf822dfaa06c791f3158bd6801e20 scudo
standalone can't be built without including sys/auxv.h.
I do not have that file on my system, and my builds have failed
when trying to simply build "all" runtimes. Assuming that "all"
means "all possible given the current environment" we need to
guard the setting of COMPILER_RT_HAS_SCUDO_STANDALONE=TRUE by
first checking if sys/auxv.h can be found.

Diff Detail

Event Timeline

bjope created this revision.Jan 29 2020, 8:23 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 29 2020, 8:23 AM
Herald added subscribers: Restricted Project, mgorny. · View Herald Transcript
Harbormaster completed remote builds in B45248: Diff 241167.Jan 29 2020, 8:26 AM
pcc accepted this revision.Jan 29 2020, 8:31 AM

LGTM

This revision is now accepted and ready to land.Jan 29 2020, 8:31 AM
Closed by commit rGf4ca2ac8225e: [scudo] Skip building scudo standalone if sys/auxv.h can't be found (authored by bjope). · Explain WhyJan 29 2020, 9:22 AM
This revision was automatically updated to reflect the committed changes.
pcc added a comment.Jan 31 2023, 2:29 PM
This comment was removed by pcc.
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2023, 2:29 PM
Herald added subscribers: yaneury, supersymetrie, Chia-hungDuan, Enna1. · View Herald Transcript

Revision Contents

PathSize
compiler-rt/
cmake/
7 lines

Diff 241193

compiler-rt/cmake/config-ix.cmake

include(CMakePushCheckState) include(CMakePushCheckState)
include(CheckCCompilerFlag) include(CheckCCompilerFlag)
include(CheckCXXCompilerFlag) include(CheckCXXCompilerFlag)
include(CheckIncludeFiles)
include(CheckLibraryExists) include(CheckLibraryExists)
include(CheckSymbolExists) include(CheckSymbolExists)
include(TestBigEndian) include(TestBigEndian)
function(check_linker_flag flag out_var) function(check_linker_flag flag out_var)
cmake_push_check_state() cmake_push_check_state()
set(CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS} ${flag}") set(CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS} ${flag}")
check_cxx_compiler_flag("" ${out_var}) check_cxx_compiler_flag("" ${out_var})
▲ Show 20 Lines • Show All 99 Lines • ▼ Show 20 Lines
check_cxx_compiler_flag(/wd4221 COMPILER_RT_HAS_WD4221_FLAG) check_cxx_compiler_flag(/wd4221 COMPILER_RT_HAS_WD4221_FLAG)
check_cxx_compiler_flag(/wd4391 COMPILER_RT_HAS_WD4391_FLAG) check_cxx_compiler_flag(/wd4391 COMPILER_RT_HAS_WD4391_FLAG)
check_cxx_compiler_flag(/wd4722 COMPILER_RT_HAS_WD4722_FLAG) check_cxx_compiler_flag(/wd4722 COMPILER_RT_HAS_WD4722_FLAG)
check_cxx_compiler_flag(/wd4800 COMPILER_RT_HAS_WD4800_FLAG) check_cxx_compiler_flag(/wd4800 COMPILER_RT_HAS_WD4800_FLAG)
# Symbols. # Symbols.
check_symbol_exists(__func__ "" COMPILER_RT_HAS_FUNC_SYMBOL) check_symbol_exists(__func__ "" COMPILER_RT_HAS_FUNC_SYMBOL)
# Includes.
check_include_files("sys/auxv.h" COMPILER_RT_HAS_AUXV)
# Libraries. # Libraries.
check_library_exists(dl dlopen "" COMPILER_RT_HAS_LIBDL) check_library_exists(dl dlopen "" COMPILER_RT_HAS_LIBDL)
check_library_exists(rt shm_open "" COMPILER_RT_HAS_LIBRT) check_library_exists(rt shm_open "" COMPILER_RT_HAS_LIBRT)
check_library_exists(m pow "" COMPILER_RT_HAS_LIBM) check_library_exists(m pow "" COMPILER_RT_HAS_LIBM)
check_library_exists(pthread pthread_create "" COMPILER_RT_HAS_LIBPTHREAD) check_library_exists(pthread pthread_create "" COMPILER_RT_HAS_LIBPTHREAD)
check_library_exists(execinfo backtrace "" COMPILER_RT_HAS_LIBEXECINFO) check_library_exists(execinfo backtrace "" COMPILER_RT_HAS_LIBEXECINFO)
# Look for terminfo library, used in unittests that depend on LLVMSupport. # Look for terminfo library, used in unittests that depend on LLVMSupport.
▲ Show 20 Lines • Show All 570 Lines • ▼ Show 20 Lines
if (COMPILER_RT_HAS_SANITIZER_COMMON AND CFI_SUPPORTED_ARCH) if (COMPILER_RT_HAS_SANITIZER_COMMON AND CFI_SUPPORTED_ARCH)
set(COMPILER_RT_HAS_CFI TRUE) set(COMPILER_RT_HAS_CFI TRUE)
else() else()
set(COMPILER_RT_HAS_CFI FALSE) set(COMPILER_RT_HAS_CFI FALSE)
endif() endif()
#TODO(kostyak): add back Android & Fuchsia when the code settles a bit. #TODO(kostyak): add back Android & Fuchsia when the code settles a bit.
if (SCUDO_STANDALONE_SUPPORTED_ARCH AND OS_NAME MATCHES "Linux") if (SCUDO_STANDALONE_SUPPORTED_ARCH AND OS_NAME MATCHES "Linux" AND
COMPILER_RT_HAS_AUXV)
set(COMPILER_RT_HAS_SCUDO_STANDALONE TRUE) set(COMPILER_RT_HAS_SCUDO_STANDALONE TRUE)
else() else()
set(COMPILER_RT_HAS_SCUDO_STANDALONE FALSE) set(COMPILER_RT_HAS_SCUDO_STANDALONE FALSE)
endif() endif()
if (COMPILER_RT_HAS_SANITIZER_COMMON AND SCUDO_SUPPORTED_ARCH AND if (COMPILER_RT_HAS_SANITIZER_COMMON AND SCUDO_SUPPORTED_ARCH AND
OS_NAME MATCHES "Linux|Android|Fuchsia") OS_NAME MATCHES "Linux|Android|Fuchsia")
set(COMPILER_RT_HAS_SCUDO TRUE) set(COMPILER_RT_HAS_SCUDO TRUE)
Show All 37 Lines