This is an archive of the discontinued LLVM Phabricator instance.

[clangd][vscode] Get rid of the deprecated vscode module in the extension.
ClosedPublic

Authored by hokein on Jan 29 2020, 6:41 AM.

Details

Summary

The vscode module has been deprecated, and it doesn't work anymore after
we require the minimal VSCode version 1.41.0, this patch migrate to the
new @type/vscode and vscode-test modules, see
https://code.visualstudio.com/api/working-with-extensions/testing-extension#migrating-from-vscode

Diff Detail

Event Timeline

hokein created this revision.Jan 29 2020, 6:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 29 2020, 6:41 AM
hokein updated this revision to Diff 241144.Jan 29 2020, 6:42 AM

add trailing blank line.

Unit tests: pass. 62287 tests passed, 0 failed and 831 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

Unit tests: fail. 62285 tests passed, 2 failed and 831 were skipped.

failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_mutex_requirements_mutex/thread_mutex_recursive/lock.pass.cpp
failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_mutex_requirements_mutex/thread_mutex_recursive/try_lock.pass.cpp

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

sammccall accepted this revision.Jan 30 2020, 2:34 AM
This revision is now accepted and ready to land.Jan 30 2020, 2:34 AM
This revision was automatically updated to reflect the committed changes.