[Instrumentation] Set hidden visibility for the bias variable

[phosek]

Summary

We have to avoid using a GOT relocation to access the bias variable,
setting the hidden visibility achieves that.

[mcgrathr]

There should be test coverage that verifies the visibility gets set, but lgtm with that.

[phosek]

Test updated

llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp

if (isRuntimeCounterRelocationEnabled()) {
     Type *Int64PtrTy = Type::getInt64PtrTy(M->getContext());
     Function *Fn = Inc->getParent()->getParent();
     Instruction &I = Fn->getEntryBlock().front();
     LoadInst *LI = dyn_cast<LoadInst>(&I);
     if (!LI) {
       IRBuilder<> Builder(&I);
       Type *Int64Ty = Type::getInt64Ty(M->getContext());
       GlobalVariable *Bias = M->getGlobalVariable(getInstrProfCounterBiasVarName());
-      if (!Bias)
+      if (!Bias) {
         Bias = new GlobalVariable(*M, Int64Ty, false, GlobalValue::LinkOnceODRLinkage,
                                   Constant::getNullValue(Int64Ty),
                                   getInstrProfCounterBiasVarName());
+        Bias->setVisibility(GlobalVariable::HiddenVisibility);
+      }
       LI = Builder.CreateLoad(Int64Ty, Bias);
     }
     auto *Add = Builder.CreateAdd(Builder.CreatePtrToInt(Addr, Int64Ty), LI);
     Addr = Builder.CreateIntToPtr(Add, Int64PtrTy);
   }
 
   if (Options.Atomic || AtomicCounterUpdateAll) {
     Builder.CreateAtomicRMW(AtomicRMWInst::Add, Addr, Inc->getStep(),

llvm/test/Instrumentation/InstrProfiling/runtime-counter-relocation.ll

 ; RUN: opt < %s -S -instrprof | FileCheck %s
 ; RUN: opt < %s -S -instrprof -runtime-counter-relocation | FileCheck -check-prefixes=RELOC %s
 
 target triple = "x86_64-unknown-linux-gnu"
 
 @__profn_foo = hidden constant [3 x i8] c"foo"
-; RELOC: @__llvm_profile_counter_bias = linkonce_odr global i64 0
+; RELOC: @__llvm_profile_counter_bias = linkonce_odr hidden global i64 0
 
 ; CHECK-LABEL: define void @foo
 ; CHECK-NEXT: %pgocount = load i64, i64* getelementptr inbounds ([1 x i64], [1 x i64]* @__profc_foo, i64 0, i64 0)
 ; CHECK-NEXT: %1 = add i64 %pgocount, 1
 ; CHECK-NEXT: store i64 %1, i64* getelementptr inbounds ([1 x i64], [1 x i64]* @__profc_foo, i64 0, i64 0)
 ; RELOC-LABEL: define void @foo
 ; RELOC-NEXT: %1 = load i64, i64* @__llvm_profile_counter_bias
 ; RELOC-NEXT: %2 = add i64 ptrtoint ([1 x i64]* @__profc_foo to i64), %1