This is an archive of the discontinued LLVM Phabricator instance.

Differential D7343

[Msan] Disable the fgetgrent_r unit test on FreeBSD
ClosedPublic

Authored by kutuzov.viktor.84 on Feb 2 2015, 5:37 AM.

Details

Reviewers
kcc
emaste
samsonov
eugenis
Commits
rCRT229387: [Msan] Disable the fgetgrent_r unit test on FreeBSD
rL229387: [Msan] Disable the fgetgrent_r unit test on FreeBSD

Diff Detail

Event Timeline

kutuzov.viktor.84 updated this revision to Diff 19149.Feb 2 2015, 5:37 AM
kutuzov.viktor.84 retitled this revision from to [Msan] Disable the fgetgrent_r unit test on FreeBSD.
kutuzov.viktor.84 updated this object.
kutuzov.viktor.84 edited the test plan for this revision. (Show Details)
kutuzov.viktor.84 added reviewers: kcc, samsonov, eugenis, emaste.
kutuzov.viktor.84 added a subscriber: Unknown Object (MLST).
eugenis accepted this revision.Feb 16 2015, 2:02 AM
eugenis edited edge metadata.

LGTM

This revision is now accepted and ready to land.Feb 16 2015, 2:02 AM
Closed by commit rL229387: [Msan] Disable the fgetgrent_r unit test on FreeBSD (authored by vkutuzov). · Explain WhyFeb 16 2015, 5:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
msan/
tests/
3 lines

Diff 19149

lib/msan/tests/msan_test.cc

Show First 20 Lines • Show All 3,352 Lines • ▼ Show 20 LinesTEST(MemorySanitizer, getgrent_r) {
ASSERT_EQ(0, res); ASSERT_EQ(0, res);
EXPECT_NOT_POISONED(grp.gr_name); EXPECT_NOT_POISONED(grp.gr_name);
ASSERT_TRUE(grp.gr_name != NULL); ASSERT_TRUE(grp.gr_name != NULL);
EXPECT_NOT_POISONED(grp.gr_name[0]); EXPECT_NOT_POISONED(grp.gr_name[0]);
EXPECT_NOT_POISONED(grp.gr_gid); EXPECT_NOT_POISONED(grp.gr_gid);
EXPECT_NOT_POISONED(grpres); EXPECT_NOT_POISONED(grpres);
} }
// There's no fgetgrent_r() on FreeBSD.
#if !defined(__FreeBSD__)
TEST(MemorySanitizer, fgetgrent_r) { TEST(MemorySanitizer, fgetgrent_r) {
FILE *fp = fopen("/etc/group", "r"); FILE *fp = fopen("/etc/group", "r");
struct group grp; struct group grp;
struct group *grpres; struct group *grpres;
char buf[10000]; char buf[10000];
setgrent(); setgrent();
int res = fgetgrent_r(fp, &grp, buf, sizeof(buf), &grpres); int res = fgetgrent_r(fp, &grp, buf, sizeof(buf), &grpres);
ASSERT_EQ(0, res); ASSERT_EQ(0, res);
EXPECT_NOT_POISONED(grp.gr_name); EXPECT_NOT_POISONED(grp.gr_name);
ASSERT_TRUE(grp.gr_name != NULL); ASSERT_TRUE(grp.gr_name != NULL);
EXPECT_NOT_POISONED(grp.gr_name[0]); EXPECT_NOT_POISONED(grp.gr_name[0]);
EXPECT_NOT_POISONED(grp.gr_gid); EXPECT_NOT_POISONED(grp.gr_gid);
EXPECT_NOT_POISONED(grpres); EXPECT_NOT_POISONED(grpres);
fclose(fp); fclose(fp);
} }
#endif
TEST(MemorySanitizer, getgroups) { TEST(MemorySanitizer, getgroups) {
int n = getgroups(0, 0); int n = getgroups(0, 0);
gid_t *gids = new gid_t[n]; gid_t *gids = new gid_t[n];
int res = getgroups(n, gids); int res = getgroups(n, gids);
ASSERT_EQ(n, res); ASSERT_EQ(n, res);
for (int i = 0; i < n; ++i) for (int i = 0; i < n; ++i)
EXPECT_NOT_POISONED(gids[i]); EXPECT_NOT_POISONED(gids[i]);
▲ Show 20 Lines • Show All 862 Lines • Show Last 20 Lines