Page MenuHomePhabricator

[mlir] NFC: Fix trivial typo in comment
ClosedPublic

Authored by kiszk on Jan 26 2020, 7:14 AM.

Details

Summary

Also, an exercise to merge this into the master myself after a reviewer gives LGTM.

Diff Detail

Event Timeline

kiszk created this revision.Jan 26 2020, 7:14 AM

Unit tests: pass. 62197 tests passed, 0 failed and 815 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

kiszk edited the summary of this revision. (Show Details)Jan 26 2020, 5:55 PM
kiszk edited the summary of this revision. (Show Details)Jan 26 2020, 6:21 PM
mehdi_amini added inline comments.Jan 26 2020, 6:29 PM
mlir/test/Transforms/loop-fusion.mlir
1625

I think the correct spelling is carrying

kiszk updated this revision to Diff 241932.Feb 2 2020, 10:29 AM

rebase with master

Unit tests: pass. 62394 tests passed, 0 failed and 839 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

mehdi_amini added inline comments.Feb 2 2020, 4:29 PM
mlir/test/Transforms/loop-fusion.mlir
1625

ping?

kiszk updated this revision to Diff 241958.Feb 2 2020, 9:01 PM
address review comment
kiszk added a comment.Feb 2 2020, 9:01 PM

You are right!! Sorry for my mistake, thank you.

Unit tests: pass. 62394 tests passed, 0 failed and 839 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

mehdi_amini accepted this revision.Feb 2 2020, 10:35 PM

LGTM, thanks!

Please cleanup your commit message from the Phabricator tags before pushing (leaving only the "Differential Revision: ..." line).

This revision is now accepted and ready to land.Feb 2 2020, 10:35 PM
This revision was automatically updated to reflect the committed changes.

LGTM, thanks!

Please cleanup your commit message from the Phabricator tags before pushing (leaving only the "Differential Revision: ..." line).

I think you pushed without cleaning up the commit description from all the tags?