This is an archive of the discontinued LLVM Phabricator instance.

Differential D73432

[mlir] NFC: Fix trivial typo in comment
ClosedPublic

Authored by kiszk on Jan 26 2020, 7:14 AM.

Details

Reviewers
nicolasvasilache
mehdi_amini
Commits
rG549588698ffa: [mlir] NFC: Fix trivial typo in comment
Summary

Also, an exercise to merge this into the master myself after a reviewer gives LGTM.

Diff Detail

Event Timeline

kiszk created this revision.Jan 26 2020, 7:14 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptJan 26 2020, 7:14 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, liufengdb, lucyrfox and 8 others. · View Herald Transcript
merge_guards_bot added a subscriber: merge_guards_bot.Jan 26 2020, 7:41 AM

Unit tests: pass. 62197 tests passed, 0 failed and 815 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

Harbormaster completed remote builds in B44951: Diff 240434.Jan 26 2020, 7:45 AM
kiszk edited the summary of this revision. (Show Details)Jan 26 2020, 5:55 PM
kiszk edited the summary of this revision. (Show Details)Jan 26 2020, 6:21 PM
mehdi_amini added inline comments.Jan 26 2020, 6:29 PM
mlir/test/Transforms/loop-fusion.mlir
1625

I think the correct spelling is carrying

kiszk updated this revision to Diff 241932.Feb 2 2020, 10:29 AM

rebase with master

Herald added a subscriber: Joonsoo. · View Herald TranscriptFeb 2 2020, 10:29 AM
merge_guards_bot added a comment.Feb 2 2020, 10:54 AM

Unit tests: pass. 62394 tests passed, 0 failed and 839 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

Harbormaster completed remote builds in B45532: Diff 241932.Feb 2 2020, 11:02 AM
mehdi_amini added inline comments.Feb 2 2020, 4:29 PM
mlir/test/Transforms/loop-fusion.mlir
1625

ping?

kiszk updated this revision to Diff 241958.Feb 2 2020, 9:01 PM
address review comment
kiszk added a comment.Feb 2 2020, 9:01 PM

You are right!! Sorry for my mistake, thank you.

merge_guards_bot added a comment.Feb 2 2020, 9:15 PM

Unit tests: pass. 62394 tests passed, 0 failed and 839 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

Harbormaster completed remote builds in B45546: Diff 241958.Feb 2 2020, 9:18 PM
mehdi_amini accepted this revision.Feb 2 2020, 10:35 PM

LGTM, thanks!

Please cleanup your commit message from the Phabricator tags before pushing (leaving only the "Differential Revision: ..." line).

This revision is now accepted and ready to land.Feb 2 2020, 10:35 PM
Closed by commit rG549588698ffa: [mlir] NFC: Fix trivial typo in comment (authored by kiszk). · Explain WhyFeb 3 2020, 12:44 AM
This revision was automatically updated to reflect the committed changes.
mehdi_amini added a comment.Feb 3 2020, 11:29 AM
In D73432#1854033, @mehdi_amini wrote:

LGTM, thanks!

Please cleanup your commit message from the Phabricator tags before pushing (leaving only the "Differential Revision: ..." line).

I think you pushed without cleaning up the commit description from all the tags?

Revision Contents

PathSize
mlir/
test/
Transforms/
2 lines

Diff 241980

mlir/test/Transforms/loop-fusion.mlir

Show First 20 Lines • Show All 1,616 Lines • ▼ Show 20 Lines affine.for %i2 = 0 to 4 {
} }
} }
// The dependence between the load and affine.store is carried on loops '%i2' and // The dependence between the load and affine.store is carried on loops '%i2' and
// '%i4', and cannot be fused with loop '%i0' without violating this // '%i4', and cannot be fused with loop '%i0' without violating this
// dependence. // dependence.
// Once loop '%i2' is interchanged with loop '%i3', and again with loop // Once loop '%i2' is interchanged with loop '%i3', and again with loop
// '%i5', then loop '%i0' can be fused at loop depth 2, because the loop // '%i5', then loop '%i0' can be fused at loop depth 2, because the loop
// carring the dependences have been interchanged with loops at depth > 2. // carrying the dependences have been interchanged with loops at depth > 2.
mehdi_aminiUnsubmitted
Not Done
ReplyInline Actions

I think the correct spelling is carrying

mehdi_amini: I think the correct spelling is `carrying`
mehdi_aminiUnsubmitted
Not Done
ReplyInline Actions

ping?

mehdi_amini: ping?
// CHECK: affine.for %{{.*}} = 0 to 6 { // CHECK: affine.for %{{.*}} = 0 to 6 {
// CHECK-NEXT: affine.for %{{.*}} = 0 to 8 { // CHECK-NEXT: affine.for %{{.*}} = 0 to 8 {
// CHECK-NEXT: affine.store %{{.*}}, %{{.*}}[0, 0] : memref<1x1xf32> // CHECK-NEXT: affine.store %{{.*}}, %{{.*}}[0, 0] : memref<1x1xf32>
// CHECK-NEXT: affine.for %{{.*}} = 0 to 4 { // CHECK-NEXT: affine.for %{{.*}} = 0 to 4 {
// CHECK-NEXT: affine.for %{{.*}} = 0 to 2 { // CHECK-NEXT: affine.for %{{.*}} = 0 to 2 {
// CHECK-NEXT: %{{.*}} = affine.load %{{.*}}[0, 0] : memref<1x1xf32> // CHECK-NEXT: %{{.*}} = affine.load %{{.*}}[0, 0] : memref<1x1xf32>
// CHECK-NEXT: %{{.*}} = addf %{{.*}}, %{{.*}} : f32 // CHECK-NEXT: %{{.*}} = addf %{{.*}}, %{{.*}} : f32
▲ Show 20 Lines • Show All 813 Lines • Show Last 20 Lines