This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/GlobalISel: Legalize f64 G_FFLOOR for SI
ClosedPublic

Authored by arsenm on Jan 24 2020, 7:10 AM.

Details

Summary

Use cmp ord instead of cmp_class compared to the DAG version for the
nan check, but mostly try to match the existsing pattern.

I think the sign doesn't matter for fract, so we could do a little
better with the source modifier matching.

I think this is also still broken as in D22898, but I'm leaving it
as-is for now while I don't have an SI system to test on.

Diff Detail

Event Timeline

arsenm created this revision.Jan 24 2020, 7:10 AM
arsenm updated this revision to Diff 240189.Jan 24 2020, 7:19 AM

Split selection test

kerbowa accepted this revision.Feb 2 2020, 12:42 AM

LGTM

llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
403

Extra newline

This revision is now accepted and ready to land.Feb 2 2020, 12:42 AM
llvm/test/CodeGen/AMDGPU/GlobalISel/floor.f64.ll