Page MenuHomePhabricator

[clangd] Rename DiagnosticsConsumer -> ClangdServer::Callbacks, and make it optional
ClosedPublic

Authored by sammccall on Fri, Jan 24, 5:09 AM.

Details

Summary

This reflects its current function better and avoids confusion with clang::DiagnosticConsumer.

The old name/constructor is left around temporarily for compatibility.
(Metagame: merging with out-of-tree changes is harder than usual this month)

Diff Detail

Event Timeline

sammccall created this revision.Fri, Jan 24, 5:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptFri, Jan 24, 5:09 AM
sammccall updated this revision to Diff 240165.Fri, Jan 24, 5:15 AM

Document new interface and threading model of existing functions.

Unit tests: fail. 62158 tests passed, 5 failed and 811 were skipped.

failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp
failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp
failed: libc++.std/language_support/cmp/cmp_strongord/strongord.pass.cpp
failed: libc++.std/language_support/cmp/cmp_weakeq/cmp.weakeq.pass.cpp
failed: libc++.std/language_support/cmp/cmp_weakord/weakord.pass.cpp

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

hokein accepted this revision.Fri, Jan 24, 5:39 AM
hokein added inline comments.
clang-tools-extra/clangd/ClangdServer.h
76

nit : clang-format.

163–164

nit: the doc is out-of-date now.

clang-tools-extra/clangd/unittests/ClangdTests.cpp
277

nit: maybe rename this class as well.

This revision is now accepted and ready to land.Fri, Jan 24, 5:39 AM

Unit tests: fail. 62158 tests passed, 5 failed and 811 were skipped.

failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp
failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp
failed: libc++.std/language_support/cmp/cmp_strongord/strongord.pass.cpp
failed: libc++.std/language_support/cmp/cmp_weakeq/cmp.weakeq.pass.cpp
failed: libc++.std/language_support/cmp/cmp_weakord/weakord.pass.cpp

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

sammccall marked 4 inline comments as done.Fri, Jan 24, 6:59 AM
sammccall added inline comments.
clang-tools-extra/clangd/ClangdServer.h
76

this is actually a clang-format bug :-\ I'll try to fix it

This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.