Page MenuHomePhabricator

[AMDGPU] Fix GCN regpressure trackers for INLINEASM instructions
ClosedPublic

Authored by vpykhtin on Jan 24 2020, 2:41 AM.

Details

Summary

Replace iteration over defs() with operands() as INLINEASM instruction isn't compatible with defs() - it has completly different order of operands: asm string, flags and pairs of flags:operand. defs() assumes all def operands go sequentally from the beginning of operands.

How LLVM could work all these years? Should an assert not using on INLINEASM in defs be added?

Not sure how to test this.

Diff Detail

Event Timeline

vpykhtin created this revision.Jan 24 2020, 2:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2020, 2:41 AM
rampitec accepted this revision.Jan 24 2020, 10:52 AM

LGTM. Thanks.

This revision is now accepted and ready to land.Jan 24 2020, 10:52 AM
This revision was automatically updated to reflect the committed changes.