Page MenuHomePhabricator

[objc_direct] do not add direct properties to the serialization array
ClosedPublic

Authored by MadCoder on Jan 22 2020, 12:11 PM.

Details

Summary

If we do, then the property_list_t length is wrong
and class_getProperty gets very sad.

Radar-Id: rdar://problem/58804805

Diff Detail

Event Timeline

MadCoder created this revision.Jan 22 2020, 12:11 PM
dexonsmith added inline comments.Jan 22 2020, 12:54 PM
clang/lib/CodeGen/CGObjCMac.cpp
3316–3319

Do you need similar logic in PushProtocolProperties?

MadCoder marked 2 inline comments as done.Jan 23 2020, 8:50 AM
MadCoder added inline comments.
clang/lib/CodeGen/CGObjCMac.cpp
3316–3319

no: you can't have anything direct in a Protocol.

This revision is now accepted and ready to land.Jan 23 2020, 9:11 AM
This revision was automatically updated to reflect the committed changes.
MadCoder marked an inline comment as done.