- User Since
- Nov 7 2019, 11:21 PM (4 w, 4 d)
@liuliu that fixes your test case (which I reproduced in the CG test)
Fri, Dec 6
@liuliu I wouldn't be surprised this addresses your issues if snapchat is using PCH
woops a bogus hunk went in
just added all the context this time (-W)
Thu, Dec 5
oh hah, thanks :)
Fix the fact that the hashmap of direct method was indexed by Declarations instead of names (and depending on code ordering, the declaration used at codegen time may be the one from the @interface or from the @implementation leading to name collisions and llvm "helpfully" adding .1's everywhere
hmm wait I have an old problem I had fixed creep up again :'(
turns out that I had no codegen check for the call site and that one of the last iteration broke it trivially :'(
Thu, Nov 21
Sun, Nov 17
Diff against previous is:
when running the full test-suite before sending the patch, and it broke tests because some loads are now ordered differently :(
Thu, Nov 14
reverted the hunk about "direct methods" note.
Updated for the new round of comments, with added tests and Sema checks errors for:
- messaging super
- messaging a nullable Class expression
Wed, Nov 13
Implemented all the tests @rjmccall wanted (and then some)
Beefed up the tests, addressed the selfValue related issue.
Updated clang/test/Misc/pragma-attribute-supported-attributes-list.test that I had forgotten.
Updated the patch to restrict objc_direct to methods and use objc_direct_members for containers, and several diagnostics improvements (especially in the vicinity of properties and the GNU runtime + tests).
Tue, Nov 12
Handled a bunch of comments (marked done).