- User Since
- Nov 7 2019, 11:21 PM (21 w, 3 d)
Mon, Mar 23
Feb 16 2020
Feb 14 2020
@erik.pilkington review feedback
Feb 10 2020
Add some errors when direct properties are marked @dynamic.
Jan 30 2020
damn you tabs!
@dexonsmith here, I still hook the same method but do it in a more LLVM-approved way ;)
Jan 23 2020
Jan 22 2020
with the test for real
adding the non ARC test I forgot to add
Jan 21 2020
fixed @ahatanak feedback
Jan 16 2020
Added some more tests to make sure it works along inheritance chains as expected
Jan 14 2020
Jan 11 2020
Dec 20 2019
Dec 19 2019
Removed the category from the direct method name mangling as discussed with @aprantl
I had forgotten to clang format and left some tabs here... some day I'll fix my vim config
Addressed @aprantl review feedback.
Small update because I uploaded before the full completion of the test-suite and somehow it's sentient and punished me... (some diagnostics were too verbose and stuttering things with Sema::CheckObjCMethodOverrides).
Dec 18 2019
Dec 16 2019
Dec 12 2019
Dec 9 2019
@liuliu that fixes your test case (which I reproduced in the CG test)
Dec 6 2019
@liuliu I wouldn't be surprised this addresses your issues if snapchat is using PCH
woops a bogus hunk went in
just added all the context this time (-W)
Dec 5 2019
oh hah, thanks :)
Fix the fact that the hashmap of direct method was indexed by Declarations instead of names (and depending on code ordering, the declaration used at codegen time may be the one from the @interface or from the @implementation leading to name collisions and llvm "helpfully" adding .1's everywhere
hmm wait I have an old problem I had fixed creep up again :'(
turns out that I had no codegen check for the call site and that one of the last iteration broke it trivially :'(
Nov 21 2019
Nov 17 2019
Diff against previous is:
when running the full test-suite before sending the patch, and it broke tests because some loads are now ordered differently :(
Nov 14 2019
reverted the hunk about "direct methods" note.
Updated for the new round of comments, with added tests and Sema checks errors for:
- messaging super
- messaging a nullable Class expression
Nov 13 2019
Implemented all the tests @rjmccall wanted (and then some)
Beefed up the tests, addressed the selfValue related issue.
Updated clang/test/Misc/pragma-attribute-supported-attributes-list.test that I had forgotten.
Updated the patch to restrict objc_direct to methods and use objc_direct_members for containers, and several diagnostics improvements (especially in the vicinity of properties and the GNU runtime + tests).