This is an archive of the discontinued LLVM Phabricator instance.

[NFC][DWARF] Use proper analog GNU attribute for the pc address
ClosedPublic

Authored by djtodoro on Jan 22 2020, 4:18 AM.

Details

Summary

The low_pc is analog to the DW_AT_call_return_pc, since it describes the return address after the call. The DW_AT_call_pc is the address of the call instruction, and we don't use it at the moment.

Diff Detail

Event Timeline

djtodoro created this revision.Jan 22 2020, 4:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 22 2020, 4:18 AM
vsk accepted this revision.Jan 22 2020, 9:41 AM

LGTM. As a heads up, according to the coverage report the DW_AT_call_target case doesn’t seem covered by a test either (lab.llvm.org:8080/coverage/coverage-reports/coverage/Users/buildslave/jenkins/workspace/coverage/llvm-project/llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp.html).

This revision is now accepted and ready to land.Jan 22 2020, 9:41 AM

Thanks for the info! I will work on adding more test cases.

This revision was automatically updated to reflect the committed changes.