To use new/delete in NVPTX code we need to define them. Implementation
copied from CUDA wrappers.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
A note: this header file requires to include stdlib.h too to see the declarations of malloc/free. Shall We include it here to fix it? otherwise the error is reported that malloc and free are declared.
Some minor comments but other than that, LGTM.
Nit: Clang format the file
clang/lib/Headers/openmp_wrappers/new | ||
---|---|---|
9 | Nit: The license usually has C++ style comments // | |
28 | Style: No braces around single statements. We could even call it unconditionally. | |
44 | Style: No braces around single statements. We could even call it unconditionally. |
Unit tests: fail. 62080 tests passed, 1 failed and 784 were skipped.
failed: Clang.Driver/cc-print-options.c
clang-tidy: unknown.
clang-format: pass.
Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml
Unit tests: fail. 62080 tests passed, 1 failed and 784 were skipped.
failed: Clang.Driver/cc-print-options.c
clang-tidy: unknown.
clang-format: pass.
Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml
Nit: The license usually has C++ style comments //