This is an archive of the discontinued LLVM Phabricator instance.

[llvm-as] Fix assembling of index with multiple summaries sharing the same GUID

Authored by evgeny777 on Jan 21 2020, 3:17 AM.



Currently llvm-as fails with error expected ')' here

Diff Detail

Event Timeline

evgeny777 created this revision.Jan 21 2020, 3:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 21 2020, 3:17 AM
tejohnson accepted this revision.Jan 21 2020, 8:40 AM


Looks like parsing of combined index assembly not well tested since no testing was relying on that functionality.

This revision is now accepted and ready to land.Jan 21 2020, 8:40 AM
thakis added a subscriber: thakis.Jan 22 2020, 4:42 AM

Looks like this breaks tests on Windows: