This is an archive of the discontinued LLVM Phabricator instance.

[llvm-exegesis] Add support for AVX512 explicit rounding operands.
ClosedPublic

Authored by courbet on Jan 21 2020, 1:14 AM.

Diff Detail

Event Timeline

courbet created this revision.Jan 21 2020, 1:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 21 2020, 1:14 AM
courbet updated this revision to Diff 239250.Jan 21 2020, 1:25 AM

Check error even when OK (debug mode tests).

gchatelet accepted this revision.Jan 21 2020, 2:35 AM
gchatelet added inline comments.
llvm/unittests/tools/llvm-exegesis/X86/SnippetGeneratorTest.cpp
211

nit: you don't need the cast to bool for ASSERT_FALSE, ASSERT_TRUE

This revision is now accepted and ready to land.Jan 21 2020, 2:35 AM
courbet updated this revision to Diff 239260.Jan 21 2020, 2:43 AM

review comments, clang-format

courbet marked an inline comment as done.Jan 21 2020, 2:43 AM

Thanks.

Harbormaster completed remote builds in B44467: Diff 239261.
This revision was automatically updated to reflect the committed changes.